]> git.ipfire.org Git - thirdparty/asterisk.git/commitdiff
res_xmpp: Correctly check return value of SSL_connect
authorSean Bright <sean.bright@gmail.com>
Thu, 23 Mar 2017 14:30:18 +0000 (10:30 -0400)
committerSean Bright <sean.bright@gmail.com>
Thu, 23 Mar 2017 14:57:57 +0000 (08:57 -0600)
SSL_connect returns non-zero for both success and some error conditions
so simply negating is inadequate.

Change-Id: Ifbf882896e598703b6c615407fa456d3199f95b1

res/res_xmpp.c

index 32e1dd1ffc9fa804f6c36585995350709118c9db..a6dfb9f90d5f1eaa45358545c50f3da1647e9e8f 100644 (file)
@@ -2672,7 +2672,7 @@ static int xmpp_client_requested_tls(struct ast_xmpp_client *client, struct ast_
                goto failure;
        }
 
-       if (!SSL_connect(client->ssl_session)) {
+       if (SSL_connect(client->ssl_session) <= 0) {
                goto failure;
        }