]> git.ipfire.org Git - thirdparty/glibc.git/commitdiff
x86-64: Compile ISA versions of modf/modff with -fno-stack-protector
authorH.J. Lu <hjl.tools@gmail.com>
Thu, 17 Jul 2025 00:17:34 +0000 (17:17 -0700)
committerH.J. Lu <hjl.tools@gmail.com>
Thu, 17 Jul 2025 12:49:47 +0000 (05:49 -0700)
Since modf and modff are compiled into both libc and libm, when glibc is
configured with --enable-stack-protector=all, ISA versions of modf and
modff should be compiled with -fno-stack-protector to avoid calling
__stack_chk_fail via PLT in libc.so.

This fixes BZ #33165.

Signed-off-by: H.J. Lu <hjl.tools@gmail.com>
Reviewed-by: Andreas K. Huettel <dilfridge@gentoo.org>
sysdeps/x86_64/fpu/multiarch/Makefile

index 5fe872b89873af2ed7f4188943b8176371a45f61..81a870d3b1dbb9fc1439bbdf5ef7444175d67a04 100644 (file)
@@ -159,11 +159,18 @@ CFLAGS-s_sin-avx.c = -msse2avx -DSSE2AVX
 CFLAGS-s_tan-avx.c = -msse2avx -DSSE2AVX
 CFLAGS-s_sincos-avx.c = -msse2avx -DSSE2AVX
 
-CFLAGS-s_modf-sse4_1.c = -msse4.1 -fno-builtin-modff32x -fno-builtin-modff64
-CFLAGS-s_modff-sse4_1.c = -msse4.1 -fno-builtin-modff32
+CFLAGS-s_modf-c.c = $(no-stack-protector)
+CFLAGS-s_modff-c.c = $(no-stack-protector)
 
-CFLAGS-s_modf-avx.c = -msse2avx -DSSE2AVX -fno-builtin-modff32x -fno-builtin-modff64
-CFLAGS-s_modff-avx.c = -msse2avx -DSSE2AVX -fno-builtin-modff32
+CFLAGS-s_modf-sse4_1.c = -msse4.1 -fno-builtin-modff32x \
+                        -fno-builtin-modff64 $(no-stack-protector)
+CFLAGS-s_modff-sse4_1.c = -msse4.1 -fno-builtin-modff32 \
+                         $(no-stack-protector)
+
+CFLAGS-s_modf-avx.c = -msse2avx -DSSE2AVX -fno-builtin-modff32x \
+                     $(no-stack-protector) -fno-builtin-modff64
+CFLAGS-s_modff-avx.c = -msse2avx -DSSE2AVX -fno-builtin-modff32 \
+                     $(no-stack-protector)
 endif
 
 ifeq ($(subdir),mathvec)