]> git.ipfire.org Git - thirdparty/util-linux.git/commitdiff
cfdisk: fix condition logic [cppcheck]
authorBoris Egorov <egorov@linux.com>
Fri, 19 Jun 2015 19:41:01 +0000 (01:41 +0600)
committerKarel Zak <kzak@redhat.com>
Thu, 25 Jun 2015 10:08:53 +0000 (12:08 +0200)
[disk-utils/cfdisk.c:1181] -> [disk-utils/cfdisk.c:1181]: (warning)
Possible null pointer dereference: data - otherwise it is redundant to
check it against null.

Signed-off-by: Boris Egorov <egorov@linux.com>
disk-utils/cfdisk.c

index 6f26a3d44de1bcc095dcede224e7c1b67c7311f5..462710719ae02c45e9123fd283ab95fc303efece 100644 (file)
@@ -1178,7 +1178,7 @@ inline static int extra_insert_pair(struct cfdisk_line *l, const char *name, con
 
        assert(l);
 
-       if (!data && !*data)
+       if (!data || !*data)
                return 0;
 
        lsl = scols_table_new_line(l->extra, NULL);