Applying suggested changes

diff --git a/src/lib/dhcpsrv/client_class_def.h b/src/lib/dhcpsrv/client_class_def.h
index 80655974de292db30bf34b32221be3713292cae8..0cede454c8746f3d9b87fb75e12bb524017cb11a 100644 (file)
--- a/src/lib/dhcpsrv/client_class_def.h
+++ b/src/lib/dhcpsrv/client_class_def.h
@@ -224,14 +224,13 @@ public:
 
     /// @brief Sets offer lifetime for the class.
     ///
-    /// Will be used for the offer lifetime (may be empty if not defined)
+    /// @param offer_lft the offer lifetime assigned to the class (may be empty if not defined)
     void setOfferLft(const util::Optional<uint32_t>& offer_lft) {
         offer_lft_ = offer_lft;
     }
 
     /// @brief Returns offer lifetime for the class.
     ///
-    /// @param inheritance inheritance mode to be used.
     /// @return offer lifetime value
     util::Optional<uint32_t> getOfferLft() const {
         return (offer_lft_);

diff --git a/src/lib/dhcpsrv/network.h b/src/lib/dhcpsrv/network.h
index e6b81bfc25492c4f8273a8020a5124142c338105..de3ce2a64a5e859e934464344417a8052cc3fa33 100644 (file)
--- a/src/lib/dhcpsrv/network.h
+++ b/src/lib/dhcpsrv/network.h
@@ -1312,7 +1312,7 @@ public:
 
     /// @brief Sets offer lifetime for the network.
     ///
-    /// Will be used for the offer lifetime (may be empty if not defined)
+    /// @param offer_lft the offer lifetime assigned to the class (may be empty if not defined)
     void setOfferLft(const util::Optional<uint32_t>& offer_lft) {
         offer_lft_ = offer_lft;
     }

diff --git a/src/lib/dhcpsrv/tests/alloc_engine4_unittest.cc b/src/lib/dhcpsrv/tests/alloc_engine4_unittest.cc
index d2e650d913bfc62c7c64a3f93b8b66cb438090c2..f375756577dd0c125e0c2bad60c08f7d0ee15c7a 100644 (file)
--- a/src/lib/dhcpsrv/tests/alloc_engine4_unittest.cc
+++ b/src/lib/dhcpsrv/tests/alloc_engine4_unittest.cc
@@ -5782,7 +5782,7 @@ TEST_F(AllocEngine4Test, discoverOfferLftReuseExpiredLease4) {
 
 // Verifies that AllocEngine::getOfferLft(ctx4) returns the appropriate
 // lifetime value based on the context content.
-TEST_F(AllocEngine4Test, getOfferft4) {
+TEST_F(AllocEngine4Test, getOfferLft4) {
     AllocEngine engine(0);
 
     // Let's make three classes, two with offer-lifetime and one without,

diff --git a/src/lib/dhcpsrv/tests/dhcp_parsers_unittest.cc b/src/lib/dhcpsrv/tests/dhcp_parsers_unittest.cc
index 9b6eb3c467887169a3832a3af40c97edb68597d1..3d6703d8506cd499f5098d9e623641216fc820a0 100644 (file)
--- a/src/lib/dhcpsrv/tests/dhcp_parsers_unittest.cc
+++ b/src/lib/dhcpsrv/tests/dhcp_parsers_unittest.cc
@@ -426,7 +426,7 @@ public:
             // position of the data element which caused failure.
             if (rcode_ != 0) {
                 EXPECT_TRUE(errorContainsPosition(status, "<string>"))
-                            << "error text:" << error_text_;
+                            << "error text: " << error_text_;
             }
         }
 

diff --git a/src/share/database/scripts/mysql/upgrade_014_to_015.sh.in b/src/share/database/scripts/mysql/upgrade_014_to_015.sh.in
index a65ac76e3848300c91370aa829470366a5103ad1..3bc0afde19435da3b0518ee49bd559ec3fde1edc 100644 (file)
--- a/src/share/database/scripts/mysql/upgrade_014_to_015.sh.in
+++ b/src/share/database/scripts/mysql/upgrade_014_to_015.sh.in
@@ -1,6 +1,6 @@
 #!/bin/sh
 
-# Copyright (C) 2022-2023 Internet Systems Consortium, Inc. ("ISC")
+# Copyright (C) 2023 Internet Systems Consortium, Inc. ("ISC")
 #
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this