]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
nodedev: avoid use of VIR_ERR_NO_* errors internally
authorJonathon Jongsma <jjongsma@redhat.com>
Tue, 30 Mar 2021 15:12:07 +0000 (10:12 -0500)
committerJonathon Jongsma <jjongsma@redhat.com>
Mon, 19 Apr 2021 15:24:13 +0000 (10:24 -0500)
These errors are demoted to debug statements[1] since they're only
intended to be used as return values for public APIs.  This makes it
difficult to debug the problem when something goes wrong since no error
message is logged. Switch instead to VIR_ERR_INTERNAL_ERROR so that the
error is logged as expected.

[1] See the implementation of daemonErrorLogFilter() for details:
https://gitlab.com/libvirt/libvirt/-/blob/e2f82a3704f680fbb37a733476d870c19232c23e/src/remote/remote_daemon.c#L89

Signed-off-by: Jonathon Jongsma <jjongsma@redhat.com>
Reviewed-by: Laine Stump <laine@redhat.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>
src/node_device/node_device_driver.c

index 0d9e80fd2345a136de0d3ee79bf9a10959a15fcc..ca3e956cae03f2acc642fac76e59c6cc2466faaf 100644 (file)
@@ -724,7 +724,7 @@ nodeDeviceGetMdevctlDefineStartCommand(virNodeDeviceDef *def,
     g_autofree char *parent_addr = nodeDeviceFindAddressByName(def->parent);
 
     if (!parent_addr) {
-        virReportError(VIR_ERR_NO_NODE_DEVICE,
+        virReportError(VIR_ERR_INTERNAL_ERROR,
                        _("unable to find parent device '%s'"), def->parent);
         return NULL;
     }