s4:auth/ntlm: let authsam_check_password_internals() add NETLOGON_NTLMV2_ENABLED

Windows returns NETLOGON_NTLMV2_ENABLED in all
netr_LogonSamLogon* response messages.
Even if NTLMv1 was actually used and also
for password authentication.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15783

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>

diff --git a/selftest/knownfail.d/samba.tests.krb5.netlogon b/selftest/knownfail.d/samba.tests.krb5.netlogon
index fa8cc1d3d327ba64dbe8e6fb12bd35d8806de3ff..dc2304c116218f73c7e7862ed3f553e9064430ee 100644 (file)
--- a/selftest/knownfail.d/samba.tests.krb5.netlogon
+++ b/selftest/knownfail.d/samba.tests.krb5.netlogon
@@ -1,22 +1,2 @@
 # This is not implemented yet
 ^samba.tests.krb5.netlogon.*.NetlogonSchannel.test_ticket_samlogon
-# We don't add NETLOGON_NTLMV2_ENABLED yet
-^samba.tests.krb5.netlogon.*.NetlogonSchannel.test_interactive_samlogon_.*_auth3_01000000
-^samba.tests.krb5.netlogon.*.NetlogonSchannel.test_interactive_samlogon_.*_auth3_613fffff
-^samba.tests.krb5.netlogon.*.NetlogonSchannel.test_interactive_samlogon_.*_auth3_e13fffff
-^samba.tests.krb5.netlogon.*.NetlogonSchannel.test_interactive_samlogon_.*_authK_80000000
-^samba.tests.krb5.netlogon.*.NetlogonSchannel.test_interactive_samlogon_.*_authK_e13fffff
-^samba.tests.krb5.netlogon.*.NetlogonSchannel.test_network_samlogon_.*_auth3_01000000
-^samba.tests.krb5.netlogon.*.NetlogonSchannel.test_network_samlogon_.*_auth3_613fffff
-^samba.tests.krb5.netlogon.*.NetlogonSchannel.test_network_samlogon_.*_auth3_e13fffff
-^samba.tests.krb5.netlogon.*.NetlogonSchannel.test_network_samlogon_.*_authK_00000000
-^samba.tests.krb5.netlogon.*.NetlogonSchannel.test_network_samlogon_.*_authK_00000004
-^samba.tests.krb5.netlogon.*.NetlogonSchannel.test_network_samlogon_.*_authK_00004000
-^samba.tests.krb5.netlogon.*.NetlogonSchannel.test_network_samlogon_.*_authK_01000000
-^samba.tests.krb5.netlogon.*.NetlogonSchannel.test_network_samlogon_.*_authK_01004004
-^samba.tests.krb5.netlogon.*.NetlogonSchannel.test_network_samlogon_.*_authK_400001ff
-^samba.tests.krb5.netlogon.*.NetlogonSchannel.test_network_samlogon_.*_authK_413fffff
-^samba.tests.krb5.netlogon.*.NetlogonSchannel.test_network_samlogon_.*_authK_603fbffb
-^samba.tests.krb5.netlogon.*.NetlogonSchannel.test_network_samlogon_.*_authK_613fffff
-^samba.tests.krb5.netlogon.*.NetlogonSchannel.test_network_samlogon_.*_authK_80000000
-^samba.tests.krb5.netlogon.*.NetlogonSchannel.test_network_samlogon_.*_authK_e13fffff

diff --git a/source4/auth/ntlm/auth_sam.c b/source4/auth/ntlm/auth_sam.c
index e3eef793cd135a0b043fde1a38dd93d795e55037..4657720316a55a7cba86d58f8c556e7270539e7e 100644 (file)
--- a/source4/auth/ntlm/auth_sam.c
+++ b/source4/auth/ntlm/auth_sam.c
@@ -1124,6 +1124,7 @@ static NTSTATUS authsam_check_password_internals(struct auth_method_context *ctx
                talloc_free(tmp_ctx);
                return nt_status;
        }
+       (*user_info_dc)->info->user_flags |= NETLOGON_NTLMV2_ENABLED;
 
        result = dsdb_is_protected_user(ctx->auth_ctx->sam_ctx,
                                        (*user_info_dc)->sids,