]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
net/mlx5e: Disable TX queues before registering the netdev
authorMaxim Mikityanskiy <maximmi@nvidia.com>
Tue, 25 Jan 2022 10:52:48 +0000 (12:52 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 13 Apr 2022 18:03:02 +0000 (20:03 +0200)
[ Upstream commit d08c6e2a4d0308a7922d7ef3b1b3af45d4096aad ]

Normally, the queues are disabled when the channels are deactivated, and
enabled when the channels are activated. However, on register, the
channels are not active, but the queues are enabled by default. This
change fixes it, preventing mlx5e_xmit from running when the channels
are deactivated in the beginning.

Signed-off-by: Maxim Mikityanskiy <maximmi@nvidia.com>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/mellanox/mlx5/core/en_main.c

index 22de7327c5a8267b19f9404369de609b37e65450..4730d6c14aebf4897515b6a87ce3a7e28cd72c76 100644 (file)
@@ -5223,6 +5223,7 @@ mlx5e_create_netdev(struct mlx5_core_dev *mdev, const struct mlx5e_profile *prof
        }
 
        netif_carrier_off(netdev);
+       netif_tx_disable(netdev);
        dev_net_set(netdev, mlx5_core_net(mdev));
 
        return netdev;