]> git.ipfire.org Git - thirdparty/libnftnl.git/commitdiff
expr: immediate: Use nft_rule_expr_set_* in the xml parsing code
authorAna Rey <anarey@gmail.com>
Sat, 21 Jun 2014 15:53:41 +0000 (17:53 +0200)
committerPablo Neira Ayuso <pablo@netfilter.org>
Mon, 23 Jun 2014 17:28:02 +0000 (19:28 +0200)
Code refactoring to use nft_rule_expr_set_* in parse functions.

Signed-off-by: Ana Rey <anarey@gmail.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
src/expr/immediate.c

index 2ea4636098f36ee667909f70fd1d748c8ab8d31b..eab1497595316b7ed759856796a674ea4b50e86e 100644 (file)
@@ -229,9 +229,7 @@ nft_rule_expr_immediate_xml_parse(struct nft_rule_expr *e, mxml_node_t *tree,
        if (nft_mxml_reg_parse(tree, "dreg", &reg, MXML_DESCEND_FIRST,
                               NFT_XML_MAND, err) != 0)
                return -1;
-
-       imm->dreg = reg;
-       e->flags |= (1 << NFT_EXPR_IMM_DREG);
+       nft_rule_expr_set_u32(e, NFT_EXPR_IMM_DREG, reg);
 
        datareg_type = nft_mxml_data_reg_parse(tree, "immediatedata",
                                               &imm->data, NFT_XML_MAND, err);