]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
media: vim2m: print device name after registering device
authorMatthew Majewski <mattwmajewski@gmail.com>
Wed, 19 Feb 2025 19:05:01 +0000 (14:05 -0500)
committerHans Verkuil <hverkuil@xs4all.nl>
Thu, 6 Mar 2025 16:33:10 +0000 (17:33 +0100)
Move the v4l2_info() call displaying the video device name after the
device is actually registered.

This fixes a bug where the driver was always displaying "/dev/video0"
since it was reading from the vfd before it was registered.

Fixes: cf7f34777a5b ("media: vim2m: Register video device after setting up internals")
Cc: stable@vger.kernel.org
Signed-off-by: Matthew Majewski <mattwmajewski@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
drivers/media/test-drivers/vim2m.c

index 6c24dcf27eb078ae2e121b81bc32ef46b34fb415..0fe97e208c02c004add8c2873f632ea0d9ef5335 100644 (file)
@@ -1314,9 +1314,6 @@ static int vim2m_probe(struct platform_device *pdev)
        vfd->v4l2_dev = &dev->v4l2_dev;
 
        video_set_drvdata(vfd, dev);
-       v4l2_info(&dev->v4l2_dev,
-                 "Device registered as /dev/video%d\n", vfd->num);
-
        platform_set_drvdata(pdev, dev);
 
        dev->m2m_dev = v4l2_m2m_init(&m2m_ops);
@@ -1343,6 +1340,9 @@ static int vim2m_probe(struct platform_device *pdev)
                goto error_m2m;
        }
 
+       v4l2_info(&dev->v4l2_dev,
+                 "Device registered as /dev/video%d\n", vfd->num);
+
 #ifdef CONFIG_MEDIA_CONTROLLER
        ret = v4l2_m2m_register_media_controller(dev->m2m_dev, vfd,
                                                 MEDIA_ENT_F_PROC_VIDEO_SCALER);