]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s3: libsmb: Cleanup - split allocation and NULL check in internal_resolve_name().
authorJeremy Allison <jra@samba.org>
Tue, 21 Jul 2020 00:28:41 +0000 (17:28 -0700)
committerIsaac Boukris <iboukris@sn-devel-184>
Tue, 4 Aug 2020 08:51:41 +0000 (08:51 +0000)
No logic change.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Isaac Boukris <iboukris@samba.org>
source3/libsmb/namequery.c

index 314484e48d5005a3472b02bdde3db11bc5212779..e20a96239c98502c166cc8a8f2df95800daf4c16 100644 (file)
@@ -2603,8 +2603,8 @@ NTSTATUS internal_resolve_name(const char *name,
                        name, name_type, sitename ? sitename : "(null)"));
 
        if (is_ipaddress(name)) {
-               if ((*return_iplist = SMB_MALLOC_P(struct ip_service)) ==
-                               NULL) {
+               *return_iplist = SMB_MALLOC_P(struct ip_service);
+               if (*return_iplist == NULL) {
                        DEBUG(0,("internal_resolve_name: malloc fail !\n"));
                        return NT_STATUS_NO_MEMORY;
                }