iproute2: Don't propogate mounts out of ip

Some systems are now following the advice in
linux/Documentation/sharedsubtrees.txt and running with all mount
points shared between all mount namespaces by default.

After creating the mount namespace call mount on / with
MS_SLAVE|MS_REC to modify all mounts in the new mount namespace to
slave mounts if they are shared or private mounts otherwise.
Guarnateeing that changes to the mount namespace created with
"ip netns exec" don't propgate to other namespaces.

Reported-by: Petr Šabata <contyk@redhat.com>
Tested-by: Petr Šabata <contyk@redhat.com>
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>

diff --git a/ip/ipnetns.c b/ip/ipnetns.c
index e41a598a847fb24049e6d1a63a746be221816abe..f2c42ba4ce817ee09a9738135f69df3f3eb63a1a 100644 (file)
--- a/ip/ipnetns.c
+++ b/ip/ipnetns.c
@@ -152,6 +152,12 @@ static int netns_exec(int argc, char **argv)
                fprintf(stderr, "unshare failed: %s\n", strerror(errno));
                return -1;
        }
+       /* Don't let any mounts propogate back to the parent */
+       if (mount("", "/", "none", MS_SLAVE | MS_REC, NULL)) {
+               fprintf(stderr, "mount --make-rslave / failed: %s\n",
+                       strerror(errno));
+               return -1;
+       }
        /* Mount a version of /sys that describes the network namespace */
        if (umount2("/sys", MNT_DETACH) < 0) {
                fprintf(stderr, "umount of /sys failed: %s\n", strerror(errno));