]> git.ipfire.org Git - thirdparty/openssl.git/commitdiff
Remove a TODO(3.0) from keymgmt_lib.c
authorMatt Caswell <matt@openssl.org>
Thu, 15 Apr 2021 15:32:45 +0000 (16:32 +0100)
committerMatt Caswell <matt@openssl.org>
Mon, 19 Apr 2021 09:45:20 +0000 (10:45 +0100)
The TODO suggest a possible refactoring. The refactoring doesn't seem
necessary at this stage. If it is required later it can be done without
affecting external APIs - so just remove the TODO.

Fixes #14397

Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/14888)

crypto/evp/keymgmt_lib.c

index f196bc4d885796b3036748cca08da26532391fe9..f3118a76c937b5a826285841eebf200d44df1f1a 100644 (file)
@@ -123,10 +123,6 @@ void *evp_keymgmt_util_export_to_provider(EVP_PKEY *pk, EVP_KEYMGMT *keymgmt)
     CRYPTO_THREAD_unlock(pk->lock);
 
     /* If the "origin" |keymgmt| doesn't support exporting, give up */
-    /*
-     * TODO(3.0) consider an evp_keymgmt_export() return value that indicates
-     * that the method is unsupported.
-     */
     if (pk->keymgmt->export == NULL)
         return NULL;