[#1982] added unittests

diff --git a/src/hooks/dhcp/mysql_cb/tests/mysql_cb_dhcp4_unittest.cc b/src/hooks/dhcp/mysql_cb/tests/mysql_cb_dhcp4_unittest.cc
index aed276db0e673990f029c04f072c71d5ed56fca0..2e23ed8395267bd40464546cf3b8af70e2cb9dca 100644 (file)
--- a/src/hooks/dhcp/mysql_cb/tests/mysql_cb_dhcp4_unittest.cc
+++ b/src/hooks/dhcp/mysql_cb/tests/mysql_cb_dhcp4_unittest.cc
@@ -591,6 +591,7 @@ TEST_F(MySqlConfigBackendDHCPv4Test, getType) {
     params["password"] = "keatest";
     params["user"] = "keatest";
     ASSERT_NO_THROW(cbptr_.reset(new MySqlConfigBackendDHCPv4(params)));
+    ASSERT_NE(cbptr_->getParameters(), DatabaseConnection::ParameterMap());
     EXPECT_EQ("mysql", cbptr_->getType());
 }
 
@@ -602,6 +603,7 @@ TEST_F(MySqlConfigBackendDHCPv4Test, getHost) {
     params["password"] = "keatest";
     params["user"] = "keatest";
     ASSERT_NO_THROW(cbptr_.reset(new MySqlConfigBackendDHCPv4(params)));
+    ASSERT_NE(cbptr_->getParameters(), DatabaseConnection::ParameterMap());
     EXPECT_EQ("localhost", cbptr_->getHost());
 }
 
@@ -612,6 +614,7 @@ TEST_F(MySqlConfigBackendDHCPv4Test, getPort) {
     params["name"] = "keatest";
     params["password"] = "keatest";
     params["user"] = "keatest";
+    ASSERT_NE(cbptr_->getParameters(), DatabaseConnection::ParameterMap());
     ASSERT_NO_THROW(cbptr_.reset(new MySqlConfigBackendDHCPv4(params)));
     EXPECT_EQ(0, cbptr_->getPort());
 }

diff --git a/src/hooks/dhcp/mysql_cb/tests/mysql_cb_dhcp6_unittest.cc b/src/hooks/dhcp/mysql_cb/tests/mysql_cb_dhcp6_unittest.cc
index 7a6acf33f43c508fb0df8ee388ad9fcb57370e13..2fc311446a9f444480d24b3733323ccb9a71adb2 100644 (file)
--- a/src/hooks/dhcp/mysql_cb/tests/mysql_cb_dhcp6_unittest.cc
+++ b/src/hooks/dhcp/mysql_cb/tests/mysql_cb_dhcp6_unittest.cc
@@ -634,6 +634,7 @@ TEST_F(MySqlConfigBackendDHCPv6Test, getType) {
     params["password"] = "keatest";
     params["user"] = "keatest";
     ASSERT_NO_THROW(cbptr_.reset(new MySqlConfigBackendDHCPv6(params)));
+    ASSERT_NE(cbptr_->getParameters(), DatabaseConnection::ParameterMap());
     EXPECT_EQ("mysql", cbptr_->getType());
 }
 
@@ -645,6 +646,7 @@ TEST_F(MySqlConfigBackendDHCPv6Test, getHost) {
     params["password"] = "keatest";
     params["user"] = "keatest";
     ASSERT_NO_THROW(cbptr_.reset(new MySqlConfigBackendDHCPv6(params)));
+    ASSERT_NE(cbptr_->getParameters(), DatabaseConnection::ParameterMap());
     EXPECT_EQ("localhost", cbptr_->getHost());
 }
 
@@ -656,6 +658,7 @@ TEST_F(MySqlConfigBackendDHCPv6Test, getPort) {
     params["password"] = "keatest";
     params["user"] = "keatest";
     ASSERT_NO_THROW(cbptr_.reset(new MySqlConfigBackendDHCPv6(params)));
+    ASSERT_NE(cbptr_->getParameters(), DatabaseConnection::ParameterMap());
     EXPECT_EQ(0, cbptr_->getPort());
 }
 

diff --git a/src/lib/dhcpsrv/testutils/generic_host_data_source_unittest.cc b/src/lib/dhcpsrv/testutils/generic_host_data_source_unittest.cc
index 26732a9f6aed6d86d1c95757e77d7da4838e6ca4..217f4e39ba37595ec4d9f8ab5731714f0168273c 100644 (file)
--- a/src/lib/dhcpsrv/testutils/generic_host_data_source_unittest.cc
+++ b/src/lib/dhcpsrv/testutils/generic_host_data_source_unittest.cc
@@ -207,6 +207,7 @@ GenericHostDataSourceTest::testReadOnlyDatabase(const char* valid_db_type) {
         VALID_PASSWORD, VALID_READONLY_DB));
 
     hdsptr_ = HostMgr::instance().getHostDataSource();
+    ASSERT_NE(hdsptr_->getParameters(), DatabaseConnection::ParameterMap());
 
     // Check that an attempt to insert new host would result in
     // exception.