_WireReader.read() should make flags a dns.flags.Flag [Issue #606]

diff --git a/dns/message.py b/dns/message.py
index 428c98e051392911e6d3980190070f226b72b5c8..ac88837987d27748afc163de3da58b4ef7af3976 100644 (file)
--- a/dns/message.py
+++ b/dns/message.py
@@ -990,7 +990,7 @@ class _WireReader:
             self.parser.get_struct('!HHHHHH')
         factory = _message_factory_from_opcode(dns.opcode.from_flags(flags))
         self.message = factory(id=id)
-        self.message.flags = flags
+        self.message.flags = dns.flags.Flag(flags)
         self.initialize_message(self.message)
         self.one_rr_per_rrset = \
             self.message._get_one_rr_per_rrset(self.one_rr_per_rrset)

diff --git a/tests/test_message.py b/tests/test_message.py
index ed48e7bdfccb5925a00ab975e57dd62a8a8753cb..19738e670858c741c5081219b376b9703dcf0563 100644 (file)
--- a/tests/test_message.py
+++ b/tests/test_message.py
@@ -676,6 +676,11 @@ flags QR
             IN SOA
 ''')
 
+    def test_from_wire_makes_Flag(self):
+        m = dns.message.from_wire(goodwire)
+        self.assertIsInstance(m.flags, dns.flags.Flag)
+        self.assertEqual(m.flags, dns.flags.Flag.RD)
+
 
 if __name__ == '__main__':
     unittest.main()