]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
tick/rcu: Fix bogus ratelimit condition
authorWen Yang <wenyang.linux@foxmail.com>
Thu, 4 May 2023 16:12:53 +0000 (00:12 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 11 Jul 2023 17:39:23 +0000 (19:39 +0200)
[ Upstream commit a7e282c77785c7eabf98836431b1f029481085ad ]

The ratelimit logic in report_idle_softirq() is broken because the
exit condition is always true:

static int ratelimit;

if (ratelimit < 10)
return false;  ---> always returns here

ratelimit++;           ---> no chance to run

Make it check for >= 10 instead.

Fixes: 0345691b24c0 ("tick/rcu: Stop allowing RCU_SOFTIRQ in idle")
Signed-off-by: Wen Yang <wenyang.linux@foxmail.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/tencent_5AAA3EEAB42095C9B7740BE62FBF9A67E007@qq.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
kernel/time/tick-sched.c

index d6fb6a676bbbb9145e7f5395008225eb0530297b..1ad89eec2a55f5b8f3a02988588298f3dda8ebcb 100644 (file)
@@ -1046,7 +1046,7 @@ static bool report_idle_softirq(void)
                        return false;
        }
 
-       if (ratelimit < 10)
+       if (ratelimit >= 10)
                return false;
 
        /* On RT, softirqs handling may be waiting on some lock */