]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
lib/dns/tests/rbt_serialize_test.c: Fix dereference before DbC check
authorOndřej Surý <ondrej@sury.org>
Fri, 27 Sep 2019 09:40:44 +0000 (11:40 +0200)
committerOndřej Surý <ondrej@sury.org>
Thu, 3 Oct 2019 07:04:27 +0000 (09:04 +0200)
lib/dns/tests/rbt_serialize_test.c

index 06f7006bd0f5148d5a1584441cc4f3af80b77abb..8a86d49985a276bb520fbf5ca955a548eeeb848e 100644 (file)
@@ -170,7 +170,7 @@ write_data(FILE *file, unsigned char *datap, void *arg, uint64_t *crc) {
 
 static isc_result_t
 fix_data(dns_rbtnode_t *p, void *base, size_t max, void *arg, uint64_t *crc) {
-       data_holder_t *data = p->data;
+       data_holder_t *data;
        size_t size;
 
        UNUSED(base);
@@ -180,6 +180,7 @@ fix_data(dns_rbtnode_t *p, void *base, size_t max, void *arg, uint64_t *crc) {
        REQUIRE(crc != NULL);
        REQUIRE(p != NULL);
 
+       data = p->data;
 
        if (data == NULL ||
            (data->len == 0 && data->data != NULL) ||