]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu_monitor: Make domainMemoryDeviceSizeChange cb return void
authorMichal Privoznik <mprivozn@redhat.com>
Mon, 25 Oct 2021 13:15:09 +0000 (15:15 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Tue, 26 Oct 2021 08:43:55 +0000 (10:43 +0200)
Nobody's interested in the return value of any of
struct _qemuMonitorCallbacks callbacks. They are all void, but
domainMemoryDeviceSizeChange. Change it to void.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
src/qemu/qemu_monitor.h
src/qemu/qemu_process.c

index 8214c2fd9f308b73ae0c52e21f5ca238d5a2f671..b54c1cf87a9ba45574c70db5ef888e635f388b61 100644 (file)
@@ -413,11 +413,11 @@ typedef void (*qemuMonitorDomainMemoryFailureCallback)(qemuMonitor *mon,
                                                        qemuMonitorEventMemoryFailure *mfp,
                                                        void *opaque);
 
-typedef int (*qemuMonitorDomainMemoryDeviceSizeChange)(qemuMonitor *mon,
-                                                       virDomainObj *vm,
-                                                       const char *alias,
-                                                       unsigned long long size,
-                                                       void *opaque);
+typedef void (*qemuMonitorDomainMemoryDeviceSizeChange)(qemuMonitor *mon,
+                                                        virDomainObj *vm,
+                                                        const char *alias,
+                                                        unsigned long long size,
+                                                        void *opaque);
 
 typedef struct _qemuMonitorCallbacks qemuMonitorCallbacks;
 struct _qemuMonitorCallbacks {
index 6027b30405dc50bc9aff90002b84151b8856652d..2a1fcad1eebea41692f10a983b7c2b8c1536c5c7 100644 (file)
@@ -1845,7 +1845,7 @@ qemuProcessHandleMemoryFailure(qemuMonitor *mon G_GNUC_UNUSED,
 }
 
 
-static int
+static void
 qemuProcessHandleMemoryDeviceSizeChange(qemuMonitor *mon G_GNUC_UNUSED,
                                         virDomainObj *vm,
                                         const char *devAlias,
@@ -1855,7 +1855,6 @@ qemuProcessHandleMemoryDeviceSizeChange(qemuMonitor *mon G_GNUC_UNUSED,
     virQEMUDriver *driver = opaque;
     struct qemuProcessEvent *processEvent = NULL;
     qemuMonitorMemoryDeviceSizeChange *info = NULL;
-    int ret = -1;
 
     virObjectLock(vm);
 
@@ -1878,11 +1877,9 @@ qemuProcessHandleMemoryDeviceSizeChange(qemuMonitor *mon G_GNUC_UNUSED,
     }
 
     processEvent = NULL;
-    ret = 0;
  cleanup:
     qemuProcessEventFree(processEvent);
     virObjectUnlock(vm);
-    return ret;
 }