]> git.ipfire.org Git - thirdparty/openembedded/openembedded-core-contrib.git/commitdiff
classes: image_types: quote variable assignment needed by dash
authorMartin Hundeb?ll <martin@geanix.com>
Mon, 27 May 2024 12:40:57 +0000 (14:40 +0200)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Thu, 30 May 2024 08:04:11 +0000 (09:04 +0100)
The change in commit 39fc503036
("classes: image_types: apply EXTRA_IMAGECMD:squashfs* in oe_mksquashfs()")
assigns $@ to a local variable without quoting it. While this works with
bash, it fails with dash. Here, only the first token of $@ is assigned
to the variable, and the reamining tokens are passed as arguments to the
"local" keyword.

Fix it by adding the missing quotes.

Signed-off-by: Martin Hundebøll <martin@geanix.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/classes-recipe/image_types.bbclass

index b4a83ae28452646c4993eded41cc83128fc47d85..2f948ecbf88bda02a95820563e2849ef71f7c114 100644 (file)
@@ -113,7 +113,7 @@ IMAGE_CMD:btrfs () {
 
 oe_mksquashfs () {
     local comp=$1; shift
-    local extra_imagecmd=$@
+    local extra_imagecmd="$@"
 
     if [ "$comp" = "zstd" ]; then
         suffix="zst"