]> git.ipfire.org Git - thirdparty/mkosi.git/commitdiff
Only validate keys and certificates that are configured
authorDaan De Meyer <daan.j.demeyer@gmail.com>
Fri, 6 Dec 2024 15:10:34 +0000 (16:10 +0100)
committerDaan De Meyer <daan.j.demeyer@gmail.com>
Fri, 6 Dec 2024 16:41:19 +0000 (17:41 +0100)
Otherwise we'll fail later on if they are not configured and are
required so let's only validate them if they actually are configured.

mkosi/__init__.py

index 83d1355decaad30827c00aa3617474829e167362..4e4f3aff053a00054dec974b8733fd0716529db8 100644 (file)
@@ -4253,7 +4253,7 @@ def validate_certificates_and_keys(config: Config) -> None:
     if not keyutil:
         return
 
-    if want_verity(config):
+    if config.verity != ConfigFeature.disabled and config.verity_certificate and config.verity_key:
         run_systemd_sign_tool(
             config,
             cmdline=[keyutil, "validate"],
@@ -4282,7 +4282,12 @@ def validate_certificates_and_keys(config: Config) -> None:
             stdout=subprocess.DEVNULL,
         )
 
-    if want_signed_pcrs(config):
+    if (
+        config.bootable != ConfigFeature.disabled
+        and config.sign_expected_pcr != ConfigFeature.disabled
+        and config.sign_expected_pcr_certificate
+        and config.sign_expected_pcr_key
+    ):
         run_systemd_sign_tool(
             config,
             cmdline=[keyutil, "validate"],