]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/log: avoid WARN when searching for usable format
authorFrancesco Valla <francesco@valla.it>
Wed, 17 Dec 2025 08:06:55 +0000 (09:06 +0100)
committerJocelyn Falempe <jfalempe@redhat.com>
Fri, 19 Dec 2025 22:06:41 +0000 (23:06 +0100)
Use drm_draw_can_convert_from_xrgb8888() instead of
drm_draw_color_from_xrgb8888() while searching for a usable color
format. This avoids a WARN in case the first format is not usable.

Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com>
Signed-off-by: Francesco Valla <francesco@valla.it>
Link: https://patch.msgid.link/20251217-drm_draw_conv_check-v3-2-15b6f8bc1cbc@valla.it
Signed-off-by: Jocelyn Falempe <jfalempe@redhat.com>
drivers/gpu/drm/clients/drm_log.c

index 4d3005273b278e8c4c0ff7a411165efb7684316e..2bd5189c967e1952f9e6ad17120b2cd920c79a96 100644 (file)
@@ -182,7 +182,7 @@ static u32 drm_log_find_usable_format(struct drm_plane *plane)
        int i;
 
        for (i = 0; i < plane->format_count; i++)
-               if (drm_draw_color_from_xrgb8888(0xffffff, plane->format_types[i]) != 0)
+               if (drm_draw_can_convert_from_xrgb8888(plane->format_types[i]))
                        return plane->format_types[i];
        return DRM_FORMAT_INVALID;
 }