]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ACPI: LPSS: Remove AudioDSP related ID
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Thu, 26 Jun 2025 13:26:05 +0000 (16:26 +0300)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Wed, 2 Jul 2025 18:09:11 +0000 (20:09 +0200)
The AudioDSP drivers are in control for all functions of the hardware
they have (they are multi-functional devices). The LPSS driver prepares
for enumeration only single devices, such as DMA, UART, SPI, I²C. Hence
the registration of AudioDSP should not be covered. Moreover, the very
same ACPI _HID has been added by the catpt driver a few years ago.

And even more serious issue with this, is that the register window at
offset 0x800 is actually D-SRAM0 in case of AudioDSP and writing to it
is a data corruption.

That all being said, remove the AudioDSP ID from the LPSS driver,
where it doesn't belong to.

Fixes: c2f8783fa2d0 ("ASoC: Intel: Add common SST driver loader on ACPI systems")
Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>
Tested-by: Cezary Rojewski <cezary.rojewski@intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://patch.msgid.link/20250626132635.221064-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/x86/lpss.c

index 258440b899a958f1f7289cbddc184a285d3cfcc3..6daa6372f9800f0efc6b281ca5ccd92e0cf327c7 100644 (file)
@@ -387,9 +387,6 @@ static const struct acpi_device_id acpi_lpss_device_ids[] = {
        { "INT3435", LPSS_ADDR(lpt_uart_dev_desc) },
        { "INT3436", LPSS_ADDR(lpt_sdio_dev_desc) },
 
-       /* Wildcat Point LPSS devices */
-       { "INT3438", LPSS_ADDR(lpt_spi_dev_desc) },
-
        { }
 };