]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
pmdomain: arm: scmi_pm_domain: remove code clutter
authorLukas Bulwahn <lukas.bulwahn@redhat.com>
Fri, 6 Jun 2025 09:08:02 +0000 (11:08 +0200)
committerUlf Hansson <ulf.hansson@linaro.org>
Wed, 18 Jun 2025 12:44:43 +0000 (14:44 +0200)
There is no need to introduce the boolean power_on to select the constant
value for state. Simply pass the value for state as argument. Just remove
this code clutter.

No functional change.

Signed-off-by: Lukas Bulwahn <lukas.bulwahn@redhat.com>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
Link: https://lore.kernel.org/r/20250606090802.597504-1-lukas.bulwahn@redhat.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/pmdomain/arm/scmi_pm_domain.c

index 2a213c218126ea08854d13e588f28497a35813c2..8fe1c0a501c9bab3283d58e89d118109c5ee1698 100644 (file)
@@ -22,27 +22,21 @@ struct scmi_pm_domain {
 
 #define to_scmi_pd(gpd) container_of(gpd, struct scmi_pm_domain, genpd)
 
-static int scmi_pd_power(struct generic_pm_domain *domain, bool power_on)
+static int scmi_pd_power(struct generic_pm_domain *domain, u32 state)
 {
-       u32 state;
        struct scmi_pm_domain *pd = to_scmi_pd(domain);
 
-       if (power_on)
-               state = SCMI_POWER_STATE_GENERIC_ON;
-       else
-               state = SCMI_POWER_STATE_GENERIC_OFF;
-
        return power_ops->state_set(pd->ph, pd->domain, state);
 }
 
 static int scmi_pd_power_on(struct generic_pm_domain *domain)
 {
-       return scmi_pd_power(domain, true);
+       return scmi_pd_power(domain, SCMI_POWER_STATE_GENERIC_ON);
 }
 
 static int scmi_pd_power_off(struct generic_pm_domain *domain)
 {
-       return scmi_pd_power(domain, false);
+       return scmi_pd_power(domain, SCMI_POWER_STATE_GENERIC_OFF);
 }
 
 static int scmi_pm_domain_probe(struct scmi_device *sdev)