]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
core: improve debug logs when failing to create symlinks in namespaces
authorLuca Boccassi <bluca@debian.org>
Fri, 6 Oct 2023 11:08:42 +0000 (12:08 +0100)
committerLuca Boccassi <luca.boccassi@gmail.com>
Fri, 6 Oct 2023 13:30:30 +0000 (14:30 +0100)
I am seeing some failures and I don't know what is failing and why even
with debug logs, so add more details

src/core/namespace.c

index feedb283cdb3210b321bac277fd49d2dd12aed2d..ffb1bb18874198a14a2d7681947e69dfe8c6ff5f 100644 (file)
@@ -1828,11 +1828,18 @@ static int create_symlinks_from_tuples(const char *root, char **strv_symlinks) {
 
                 r = mkdir_parents_label(dst_abs, 0755);
                 if (r < 0)
-                        return r;
+                        return log_debug_errno(
+                                        r,
+                                        "Failed to create parent directory for symlink '%s': %m",
+                                        dst_abs);
 
                 r = symlink_idempotent(src_abs, dst_abs, true);
                 if (r < 0)
-                        return r;
+                        return log_debug_errno(
+                                        r,
+                                        "Failed to create symlink from '%s' to '%s': %m",
+                                        src_abs,
+                                        dst_abs);
         }
 
         return 0;