]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
domain_conf: make virDomainControllerDriverFormat() void
authorMatt Coleman <mcoleman@datto.com>
Fri, 6 Nov 2020 03:32:48 +0000 (22:32 -0500)
committerMichal Privoznik <mprivozn@redhat.com>
Wed, 11 Nov 2020 11:53:11 +0000 (12:53 +0100)
This function always returns zero, so it might as well be void.

Signed-off-by: Matt Coleman <matt@datto.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/conf/domain_conf.c

index 5e74c0de4aef667e5f55902d7ff9cdb86caa5805..a6253a999d55350f3a70dc7f58aa8ee24c09b70d 100644 (file)
@@ -25918,7 +25918,7 @@ virDomainDiskDefFormat(virBufferPtr buf,
 }
 
 
-static int
+static void
 virDomainControllerDriverFormat(virBufferPtr buf,
                                 virDomainControllerDefPtr def)
 {
@@ -25944,8 +25944,6 @@ virDomainControllerDriverFormat(virBufferPtr buf,
     virDomainVirtioOptionsFormat(&driverBuf, def->virtio);
 
     virXMLFormatElement(buf, "driver", &driverBuf, NULL);
-
-    return 0;
 }
 
 
@@ -26092,8 +26090,7 @@ virDomainControllerDefFormat(virBufferPtr buf,
         }
     }
 
-    if (virDomainControllerDriverFormat(&childBuf, def) < 0)
-        return -1;
+    virDomainControllerDriverFormat(&childBuf, def);
 
     virDomainDeviceInfoFormat(&childBuf, &def->info, flags);