Merge pull request #2264 in SNORT/snort3 from ~SATHIRKA/snort3:appid_cert_viz_api...

Squashed commit of the following:

commit c0da3e4f26a12b4e8e7a07da6a5d9df6eac73b11
Author: Sreeja Athirkandathil Narayanan <sathirka@cisco.com>
Date:   Thu May 21 16:25:10 2020 -0400

    appid: Update cert viz API to handle subject alt name and SNI mismatch

diff --git a/src/network_inspectors/appid/appid_api.cc b/src/network_inspectors/appid/appid_api.cc
index 514aa5aa2d27f86c8429594b7c9335ea37ac7927..7de798a5ad01b63f60aa93b537a19c370c99e47f 100644 (file)
--- a/src/network_inspectors/appid/appid_api.cc
+++ b/src/network_inspectors/appid/appid_api.cc
@@ -205,8 +205,9 @@ uint32_t AppIdApi::consume_ha_state(Flow& flow, const uint8_t* buf, uint8_t, IpP
     return sizeof(*appHA);
 }
 
-bool AppIdApi::ssl_app_group_id_lookup(Flow* flow, const char* server_name, const char* common_name,
-    AppId& service_id, AppId& client_id, AppId& payload_id, const char* org_unit)
+bool AppIdApi::ssl_app_group_id_lookup(Flow* flow, const char* server_name,
+    const char* first_alt_name, const char* common_name, const char* org_unit,
+    bool sni_mismatch, AppId& service_id, AppId& client_id, AppId& payload_id)
 {
     AppIdSession* asd = nullptr;
     service_id = APP_ID_NONE;
@@ -221,34 +222,60 @@ bool AppIdApi::ssl_app_group_id_lookup(Flow* flow, const char* server_name, cons
         AppidChangeBits change_bits;
         SslPatternMatchers& ssl_matchers = asd->ctxt.get_odp_ctxt().get_ssl_matchers();
         if (!asd->tsession)
-            asd->tsession = (TlsSession*)snort_calloc(sizeof(TlsSession));
+            asd->tsession = new TlsSession();
+        else if (sni_mismatch)
+            asd->tsession->set_tls_host(nullptr, 0, change_bits);
 
-        if (server_name)
+        if (sni_mismatch)
+            asd->scan_flags |= SCAN_SPOOFED_SNI_FLAG;
+
+        if (server_name and !sni_mismatch)
         {
-            ssl_matchers.scan_hostname((const uint8_t*)server_name, strlen(server_name), client_id,
-                payload_id);
             asd->tsession->set_tls_host(server_name, strlen(server_name), change_bits);
-            asd->scan_flags |= SCAN_SSL_HOST_FLAG;
-            asd->scan_flags |= SCAN_DO_NOT_OVERRIDE_SERVER_NAME_FLAG;
+            ssl_matchers.scan_hostname((const uint8_t*)server_name, strlen(server_name),
+                client_id, payload_id);
+            if (client_id != APP_ID_NONE or payload_id != APP_ID_NONE)
+                asd->tsession->set_matched_tls_type(MatchedTlsType::MATCHED_TLS_HOST);
+        }
+
+        if (first_alt_name)
+        {
+            asd->tsession->set_tls_first_alt_name(first_alt_name, strlen(first_alt_name), change_bits);
+            if (client_id == APP_ID_NONE and payload_id == APP_ID_NONE)
+            {
+                ssl_matchers.scan_hostname((const uint8_t*)first_alt_name, strlen(first_alt_name),
+                    client_id, payload_id);
+                if (client_id != APP_ID_NONE or payload_id != APP_ID_NONE)
+                    asd->tsession->set_matched_tls_type(MatchedTlsType::MATCHED_TLS_FIRST_SAN);
+            }
         }
 
         if (common_name)
         {
-            ssl_matchers.scan_cname((const uint8_t*)common_name, strlen(common_name), client_id,
-                payload_id);
             asd->tsession->set_tls_cname(common_name, strlen(common_name), change_bits);
-            asd->scan_flags |= SCAN_SSL_CERTIFICATE_FLAG;
-            asd->scan_flags |= SCAN_DO_NOT_OVERRIDE_COMMON_NAME_FLAG;
+            if (client_id == APP_ID_NONE and payload_id == APP_ID_NONE)
+            {
+                ssl_matchers.scan_cname((const uint8_t*)common_name, strlen(common_name),
+                    client_id, payload_id);
+                if (client_id != APP_ID_NONE or payload_id != APP_ID_NONE)
+                    asd->tsession->set_matched_tls_type(MatchedTlsType::MATCHED_TLS_CNAME);
+            }
         }
 
         if (org_unit)
         {
-            ssl_matchers.scan_cname((const uint8_t*)org_unit, strlen(org_unit), client_id,
-                payload_id);
-             asd->tsession->set_tls_org_unit(org_unit, strlen(org_unit));
-             asd->scan_flags |= SCAN_DO_NOT_OVERRIDE_ORG_NAME_FLAG;
+            asd->tsession->set_tls_org_unit(org_unit, strlen(org_unit));
+            if (client_id == APP_ID_NONE and payload_id == APP_ID_NONE)
+            {
+                ssl_matchers.scan_cname((const uint8_t*)org_unit, strlen(org_unit),
+                    client_id, payload_id);
+                if (client_id != APP_ID_NONE or payload_id != APP_ID_NONE)
+                    asd->tsession->set_matched_tls_type(MatchedTlsType::MATCHED_TLS_ORG_UNIT);
+            }
         }
 
+        asd->scan_flags |= SCAN_CERTVIZ_ENABLED_FLAG;
+
         service_id = asd->get_application_ids_service();
         AppId misc_id = asd->get_application_ids_misc();
 
@@ -273,18 +300,18 @@ bool AppIdApi::ssl_app_group_id_lookup(Flow* flow, const char* server_name, cons
         {
             SslPatternMatchers& ssl_matchers = inspector->get_ctxt().get_odp_ctxt().get_ssl_matchers();
 
-            if (server_name)
+            if (server_name and !sni_mismatch)
                 ssl_matchers.scan_hostname((const uint8_t*)server_name, strlen(server_name),
                     client_id, payload_id);
-
-            if (common_name)
+            if (first_alt_name and client_id == APP_ID_NONE and payload_id == APP_ID_NONE)
+                ssl_matchers.scan_hostname((const uint8_t*)first_alt_name, strlen(first_alt_name),
+                    client_id, payload_id);
+            if (common_name and client_id == APP_ID_NONE and payload_id == APP_ID_NONE)
                 ssl_matchers.scan_cname((const uint8_t*)common_name, strlen(common_name), client_id,
                     payload_id);
-
-            if (org_unit)
+            if (org_unit and client_id == APP_ID_NONE and payload_id == APP_ID_NONE)
                 ssl_matchers.scan_cname((const uint8_t*)org_unit, strlen(org_unit), client_id,
                     payload_id);
-
         }
     }
 

diff --git a/src/network_inspectors/appid/appid_api.h b/src/network_inspectors/appid/appid_api.h
index f0850af2657937ae529ba86baa56d849760ff0cb..30a01b4b9258415763127cf380b962aa08df7f1f 100644 (file)
--- a/src/network_inspectors/appid/appid_api.h
+++ b/src/network_inspectors/appid/appid_api.h
@@ -59,8 +59,8 @@ public:
     uint32_t produce_ha_state(const Flow& flow, uint8_t* buf);
     uint32_t consume_ha_state(Flow& flow, const uint8_t* buf, uint8_t length, IpProtocol,
         SfIp*, uint16_t initiatorPort);
-    bool ssl_app_group_id_lookup(Flow* flow, const char*, const char*, AppId& service_id,
-        AppId& client_id, AppId& payload_id, const char* org_unit = nullptr);
+    bool ssl_app_group_id_lookup(Flow* flow, const char*, const char*, const char*,
+        const char*, bool, AppId& service_id, AppId& client_id, AppId& payload_id);
     AppIdSessionApi* create_appid_session_api(const Flow& flow);
     void free_appid_session_api(AppIdSessionApi* api);
     bool is_inspection_needed(const Inspector& g) const;

diff --git a/src/network_inspectors/appid/appid_discovery.h b/src/network_inspectors/appid/appid_discovery.h
index d894deab8f2d1c0dc6b5b7ded41a15db0db579c4..bf80eceb4b2a267264d461135b68fafc5cda5ae6 100644 (file)
--- a/src/network_inspectors/appid/appid_discovery.h
+++ b/src/network_inspectors/appid/appid_discovery.h
@@ -57,9 +57,8 @@ struct Packet;
 #define SCAN_HTTP_XWORKINGWITH_FLAG (1<<7)
 #define SCAN_HTTP_CONTENT_TYPE_FLAG (1<<8)
 #define SCAN_HTTP_URI_FLAG          (1<<9)
-#define SCAN_DO_NOT_OVERRIDE_SERVER_NAME_FLAG (1<<10)
-#define SCAN_DO_NOT_OVERRIDE_COMMON_NAME_FLAG (1<<11)
-#define SCAN_DO_NOT_OVERRIDE_ORG_NAME_FLAG    (1<<12)
+#define SCAN_CERTVIZ_ENABLED_FLAG   (1<<10)
+#define SCAN_SPOOFED_SNI_FLAG       (1<<11)
 
 class AppIdPatternMatchNode
 {

diff --git a/src/network_inspectors/appid/appid_session.cc b/src/network_inspectors/appid/appid_session.cc
index c0d844fac3811c2433f94c5d2ba3fe64c553c8be..57330509eecec32c7e00123f2873d7ff1b75cfef 100644 (file)
--- a/src/network_inspectors/appid/appid_session.cc
+++ b/src/network_inspectors/appid/appid_session.cc
@@ -477,6 +477,9 @@ void AppIdSession::examine_ssl_metadata(AppidChangeBits& change_bits)
     AppId payload_id = 0;
     const char* tls_str = tsession->get_tls_host();
 
+    if (scan_flags & SCAN_CERTVIZ_ENABLED_FLAG)
+        return;
+
     if ((scan_flags & SCAN_SSL_HOST_FLAG) and tls_str)
     {
         size_t size = strlen(tls_str);
@@ -610,16 +613,6 @@ bool AppIdSession::is_svc_taking_too_much_time()
         init_bytes_without_reply > ctxt.get_odp_ctxt().max_bytes_before_service_fail));
 }
 
-void AppIdSession::free_tls_session_data()
-{
-    if (tsession)
-    {
-        tsession->free_data();
-        snort_free(tsession);
-        tsession = nullptr;
-    }
-}
-
 void AppIdSession::delete_session_data()
 {
     service.reset();
@@ -640,7 +633,8 @@ void AppIdSession::delete_session_data()
     }
 
     delete_all_http_sessions();
-    free_tls_session_data();
+    if (tsession)
+        delete tsession;
     delete dsession;
 }
 

diff --git a/src/network_inspectors/appid/appid_session.h b/src/network_inspectors/appid/appid_session.h
index 150eb052502711bbefc301b37aa21edf3622b6be..b82b0a31a0be484cffa0a2d3fcff3fafd59f7d02 100644 (file)
--- a/src/network_inspectors/appid/appid_session.h
+++ b/src/network_inspectors/appid/appid_session.h
@@ -128,14 +128,56 @@ struct CommonAppIdData
     uint16_t initiator_port = 0;
 };
 
-// FIXIT-L: make these const strings
-struct TlsSession
+enum MatchedTlsType
 {
-    char* get_tls_host() { return tls_host; }
+    MATCHED_TLS_NONE = 0,
+    MATCHED_TLS_HOST,
+    MATCHED_TLS_FIRST_SAN,
+    MATCHED_TLS_CNAME,
+    MATCHED_TLS_ORG_UNIT,
+};
+
+class TlsSession
+{
+public:
+    ~TlsSession()
+    {
+        if (tls_host)
+            snort_free(tls_host);
+        if (tls_first_alt_name)
+            snort_free(tls_first_alt_name);
+        if (tls_cname)
+            snort_free(tls_cname);
+        if (tls_org_unit)
+            snort_free(tls_org_unit);
+    }
 
-    char* get_tls_cname() { return tls_cname; }
+    const char* get_tls_host() const
+    {
+        switch (matched_tls_type)
+        {
+            case MATCHED_TLS_HOST:
+                return tls_host;
+            case MATCHED_TLS_FIRST_SAN:
+                return tls_first_alt_name;
+            case MATCHED_TLS_CNAME:
+                return tls_cname;
+            default:
+                if (tls_host)
+                    return tls_host;
+                else if (tls_first_alt_name)
+                    return tls_first_alt_name;
+                else if (tls_cname)
+                    return tls_cname;
+        }
+        return nullptr;
+    }
 
-    char* get_tls_org_unit() { return tls_org_unit; }
+    const char* get_tls_first_alt_name() const { return tls_first_alt_name; }
+
+    const char* get_tls_cname() const { return tls_cname; }
+
+    const char* get_tls_org_unit() const { return tls_org_unit; }
 
     bool get_tls_handshake_done() { return tls_handshake_done; }
 
@@ -153,6 +195,21 @@ struct TlsSession
         change_bits.set(APPID_TLSHOST_BIT);
     }
 
+    void set_tls_first_alt_name(const char* new_tls_first_alt_name, uint32_t len, AppidChangeBits& change_bits)
+    {
+        if (tls_first_alt_name)
+            snort_free(tls_first_alt_name);
+        if (!new_tls_first_alt_name or *new_tls_first_alt_name == '\0')
+        {
+            tls_first_alt_name = nullptr;
+            return;
+        }
+        tls_first_alt_name = len? snort::snort_strndup(new_tls_first_alt_name, len) :
+            const_cast<char*>(new_tls_first_alt_name);
+        if (!tls_host)
+            change_bits.set(APPID_TLSHOST_BIT);
+    }
+
     void set_tls_cname(const char* new_tls_cname, uint32_t len, AppidChangeBits& change_bits)
     {
         if (tls_cname)
@@ -183,23 +240,18 @@ struct TlsSession
 
     void set_tls_handshake_done() { tls_handshake_done = true; }
 
-    void free_data()
+    void set_matched_tls_type(MatchedTlsType type)
     {
-        if (tls_host)
-            snort_free(tls_host);
-        if (tls_cname)
-            snort_free(tls_cname);
-        if (tls_org_unit)
-            snort_free(tls_org_unit);
-        tls_host = tls_cname = tls_org_unit = nullptr;
-        tls_handshake_done = false;
+        matched_tls_type = type;
     }
 
 private:
     char* tls_host = nullptr;
+    char* tls_first_alt_name = nullptr;
     char* tls_cname = nullptr;
     char* tls_org_unit = nullptr;
     bool tls_handshake_done = false;
+    MatchedTlsType matched_tls_type = MATCHED_TLS_NONE;
 };
 
 class AppIdSession : public snort::FlowData
@@ -313,7 +365,6 @@ public:
     void* remove_flow_data(unsigned id);
     void free_flow_data_by_id(unsigned id);
     void free_flow_data_by_mask(unsigned mask);
-    void free_tls_session_data();
     void free_flow_data();
 
     AppId pick_service_app_id();

diff --git a/src/network_inspectors/appid/appid_session_api.cc b/src/network_inspectors/appid/appid_session_api.cc
index 73d07e7093c72c704c46c86d2a4e41ee51f96579..23de6590e6d315e677cdf1f1fa9bfd2a39c8f57b 100644 (file)
--- a/src/network_inspectors/appid/appid_session_api.cc
+++ b/src/network_inspectors/appid/appid_session_api.cc
@@ -239,16 +239,10 @@ short AppIdSessionApi::get_service_port()
     return asd->service_port;
 }
 
-char* AppIdSessionApi::get_tls_host()
+const char* AppIdSessionApi::get_tls_host()
 {
     if (asd->tsession)
-    {
-        if (asd->tsession->get_tls_host())
-            return asd->tsession->get_tls_host();
-        else
-            return asd->tsession->get_tls_cname();
-    }
-
+        return asd->tsession->get_tls_host();
     return nullptr;
 }
 

diff --git a/src/network_inspectors/appid/appid_session_api.h b/src/network_inspectors/appid/appid_session_api.h
index 4bd1f348e392ed300ca34fde2dd9fa357a1632d4..f7977e8bcfc3fc16fdddb3b2622a5a0250192dd9 100644 (file)
--- a/src/network_inspectors/appid/appid_session_api.h
+++ b/src/network_inspectors/appid/appid_session_api.h
@@ -170,7 +170,7 @@ public:
     SfIp* get_initiator_ip();
     AppIdDnsSession* get_dns_session();
     AppIdHttpSession* get_http_session(uint32_t stream_index = 0);
-    char* get_tls_host();
+    const char* get_tls_host();
     DHCPData* get_dhcp_fp_data();
     void free_dhcp_fp_data(DHCPData*);
     DHCPInfo* get_dhcp_info();

diff --git a/src/network_inspectors/appid/service_plugins/service_ssl.cc b/src/network_inspectors/appid/service_plugins/service_ssl.cc
index b5ce748845aed09d098c6c023b29ec643e9a8a99..0618f32cc2e0eb2db543cbbe229fc9f35e919a9d 100644 (file)
--- a/src/network_inspectors/appid/service_plugins/service_ssl.cc
+++ b/src/network_inspectors/appid/service_plugins/service_ssl.cc
@@ -333,9 +333,7 @@ static void parse_client_initiation(const uint8_t* data, uint16_t size, ServiceS
 
             const uint8_t* str = data + offsetof(ServiceSSLV3ExtensionServerName, string_length) +
                 sizeof(ext->string_length);
-            ss->host_name = (char*)snort_alloc(len + 1);  //Plus nullptr term.
-            memcpy(ss->host_name, str, len);
-            ss->host_name[len] = '\0';
+            ss->host_name = snort_strndup((const char*)str, len);
             ss->host_name_strlen = len;
             return;
         }
@@ -349,7 +347,7 @@ static void parse_client_initiation(const uint8_t* data, uint16_t size, ServiceS
     }
 }
 
-static bool parse_certificates(ServiceSSLData* ss, AppIdDiscoveryArgs& args)
+static bool parse_certificates(ServiceSSLData* ss)
 {
     bool success = false;
     if (ss->certs_data and ss->certs_len)
@@ -390,7 +388,7 @@ static bool parse_certificates(ServiceSSLData* ss, AppIdDiscoveryArgs& args)
             {
                 if ((cert_name = X509_NAME_oneline(X509_get_subject_name(cert), nullptr, 0)))
                 {
-                    if (!(args.asd.scan_flags & SCAN_DO_NOT_OVERRIDE_COMMON_NAME_FLAG) and !common_name)
+                    if (!common_name)
                     {
                         if ((start = strstr(cert_name, COMMON_NAME_STR)))
                         {
@@ -407,7 +405,7 @@ static bool parse_certificates(ServiceSSLData* ss, AppIdDiscoveryArgs& args)
                             start = nullptr;
                         }
                     }
-                    if (!(args.asd.scan_flags & SCAN_DO_NOT_OVERRIDE_ORG_NAME_FLAG) and !org_name)
+                    if (!org_name)
                     {
                         if ((start = strstr(cert_name, COMMON_NAME_STR)))
                         {
@@ -479,7 +477,7 @@ int SslServiceDetector::validate(AppIdDiscoveryArgs& args)
     {
         ss->state = SSL_STATE_CONNECTION;
 
-        if (!(args.asd.scan_flags & SCAN_DO_NOT_OVERRIDE_SERVER_NAME_FLAG) and
+        if (!(args.asd.scan_flags & SCAN_CERTVIZ_ENABLED_FLAG) and
             args.dir == APP_ID_FROM_INITIATOR)
         {
             parse_client_initiation(data, size, ss);
@@ -698,9 +696,8 @@ fail:
 success:
     if (ss->certs_data && ss->certs_len)
     {
-        if (!((args.asd.scan_flags & SCAN_DO_NOT_OVERRIDE_COMMON_NAME_FLAG) and
-            (args.asd.scan_flags & SCAN_DO_NOT_OVERRIDE_ORG_NAME_FLAG)) and
-            (!parse_certificates(ss, args)))
+        if (!(args.asd.scan_flags & SCAN_CERTVIZ_ENABLED_FLAG) and
+            (!parse_certificates(ss)))
         {
             goto fail;
         }
@@ -710,7 +707,7 @@ success:
     if (ss->host_name || ss->common_name || ss->org_name)
     {
         if (!args.asd.tsession)
-            args.asd.tsession = (TlsSession*)snort_calloc(sizeof(TlsSession));
+            args.asd.tsession = new TlsSession();
 
         /* TLS Host */
         if (ss->host_name)

diff --git a/src/network_inspectors/appid/test/appid_api_test.cc b/src/network_inspectors/appid/test/appid_api_test.cc
index 3a621915dd4bd45e1559085aed3f8b53abca22ec..34495d0c354ecb9ef5516d3c261a9cdf4bebfd7f 100644 (file)
--- a/src/network_inspectors/appid/test/appid_api_test.cc
+++ b/src/network_inspectors/appid/test/appid_api_test.cc
@@ -77,10 +77,18 @@ void AppIdSession::publish_appid_event(AppidChangeBits& change_bits, Flow* flow,
     DataBus::publish(APPID_EVENT_ANY_CHANGE, app_event, flow);
 }
 
-bool SslPatternMatchers::scan_hostname(unsigned char const*, unsigned long, AppId& client_id, AppId& payload_id)
+bool SslPatternMatchers::scan_hostname(unsigned char const* server_name, unsigned long, AppId& client_id, AppId& payload_id)
 {
-    client_id = APPID_UT_ID + 1;
-    payload_id = APPID_UT_ID + 1;
+    if (((const char*)server_name) == APPID_UT_TLS_HOST)
+    {
+        client_id = APPID_UT_ID + 1;
+        payload_id = APPID_UT_ID + 1;
+    }
+    else
+    {
+        client_id = 0;
+        payload_id = 0;
+    }
     return true;
 }
 
@@ -93,8 +101,8 @@ bool SslPatternMatchers::scan_cname(unsigned char const* cname, unsigned long, A
     }
     else
     {
-        client_id = APPID_UT_ID + 3;
-        payload_id = APPID_UT_ID + 3;
+        client_id = 0;
+        payload_id = 0;
     }
     return true;
 }
@@ -223,14 +231,16 @@ TEST(appid_api, ssl_app_group_id_lookup)
     AppId service, client, payload = APP_ID_NONE;
     bool val = false;
     mock_session->common.flow_type = APPID_FLOW_TYPE_IGNORE;
-    val = appid_api.ssl_app_group_id_lookup(flow, nullptr, nullptr, service, client, payload);
+    val = appid_api.ssl_app_group_id_lookup(flow, nullptr, nullptr, nullptr, nullptr,
+        false, service, client, payload);
     CHECK_TRUE(!val);
     CHECK_EQUAL(service, APP_ID_NONE);
     CHECK_EQUAL(client, APP_ID_NONE);
     CHECK_EQUAL(payload, APP_ID_NONE);
 
     mock_session->common.flow_type = APPID_FLOW_TYPE_NORMAL;
-    val = appid_api.ssl_app_group_id_lookup(flow, nullptr, nullptr, service, client, payload);
+    val = appid_api.ssl_app_group_id_lookup(flow, nullptr, nullptr, nullptr, nullptr,
+        false, service, client, payload);
     CHECK_TRUE(val);
     CHECK_EQUAL(service, APPID_UT_ID);
     CHECK_EQUAL(client, APPID_UT_ID);
@@ -240,10 +250,14 @@ TEST(appid_api, ssl_app_group_id_lookup)
     service = APP_ID_NONE;
     client = APP_ID_NONE;
     payload = APP_ID_NONE;
-    val = appid_api.ssl_app_group_id_lookup(flow, (const char*)APPID_UT_TLS_HOST, nullptr, service, client, payload);
+    val = appid_api.ssl_app_group_id_lookup(flow, (const char*)APPID_UT_TLS_HOST, (const char*)APPID_UT_TLS_HOST,
+        (const char*)APPID_UT_TLS_HOST, (const char*)APPID_UT_TLS_HOST, false, service, client, payload);
     CHECK_TRUE(val);
     CHECK_EQUAL(client, APPID_UT_ID + 1);
     CHECK_EQUAL(payload, APPID_UT_ID + 1);
+    STRCMP_EQUAL(mock_session->tsession->get_tls_host(), APPID_UT_TLS_HOST);
+    STRCMP_EQUAL(mock_session->tsession->get_tls_first_alt_name(), APPID_UT_TLS_HOST);
+    STRCMP_EQUAL(mock_session->tsession->get_tls_cname(), APPID_UT_TLS_HOST);
     STRCMP_EQUAL("Published change_bits == 000001000110", test_log);
 
     AppidChangeBits change_bits;
@@ -253,8 +267,8 @@ TEST(appid_api, ssl_app_group_id_lookup)
     STRCMP_EQUAL(mock_session->tsession->get_tls_host(), "www.cisco.com");
     STRCMP_EQUAL(mock_session->tsession->get_tls_cname(), "www.cisco.com");
     STRCMP_EQUAL(mock_session->tsession->get_tls_org_unit(), "Cisco");
-    val = appid_api.ssl_app_group_id_lookup(flow, (const char*)APPID_UT_TLS_HOST,
-        (const char*)APPID_UT_TLS_HOST, service, client, payload);
+    val = appid_api.ssl_app_group_id_lookup(flow, (const char*)"www.google.com",
+        nullptr, (const char*)APPID_UT_TLS_HOST, nullptr, false, service, client, payload);
     CHECK_TRUE(val);
     CHECK_EQUAL(client, APPID_UT_ID + 2);
     CHECK_EQUAL(payload, APPID_UT_ID + 2);
@@ -264,15 +278,15 @@ TEST(appid_api, ssl_app_group_id_lookup)
     STRCMP_EQUAL("Published change_bits == 000001000110", test_log);
 
     string host = "";
-    val = appid_api.ssl_app_group_id_lookup(flow, (const char*)(host.c_str()),
-        (const char*)APPID_UT_TLS_HOST, service, client, payload, (const char*)("Google"));
+    val = appid_api.ssl_app_group_id_lookup(flow, (const char*)(host.c_str()), nullptr,
+        (const char*)APPID_UT_TLS_HOST, (const char*)"Google", false, service, client, payload);
     CHECK_TRUE(val);
-    CHECK_EQUAL(client, APPID_UT_ID + 3);
-    CHECK_EQUAL(payload, APPID_UT_ID + 3);
-    STRCMP_EQUAL(mock_session->tsession->get_tls_host(), nullptr);
+    CHECK_EQUAL(client, APPID_UT_ID + 2);
+    CHECK_EQUAL(payload, APPID_UT_ID + 2);
+    STRCMP_EQUAL(mock_session->tsession->get_tls_host(), APPID_UT_TLS_HOST);
     STRCMP_EQUAL(mock_session->tsession->get_tls_cname(), APPID_UT_TLS_HOST);
     STRCMP_EQUAL(mock_session->tsession->get_tls_org_unit(), "Google");
-    STRCMP_EQUAL("Published change_bits == 000001000110", test_log);
+    STRCMP_EQUAL("Published change_bits == 000001000000", test_log);
     mock().checkExpectations();
 }
 

diff --git a/src/network_inspectors/appid/test/appid_discovery_test.cc b/src/network_inspectors/appid/test/appid_discovery_test.cc
index 079c0a77e3319dc831105b56388ff1782487d68c..ea394407fcde550c03dbcde6be0756f8c7b51e87 100644 (file)
--- a/src/network_inspectors/appid/test/appid_discovery_test.cc
+++ b/src/network_inspectors/appid/test/appid_discovery_test.cc
@@ -396,7 +396,7 @@ TEST(appid_discovery_tests, change_bits_for_tls_host)
 {
     // Testing set_tls_host
     AppidChangeBits change_bits;
-    const char* host = "www.cisco.com";
+    char* host = snort_strdup(APPID_UT_TLS_HOST);
     TlsSession tls;
     tls.set_tls_host(host, 0, change_bits);
 

diff --git a/src/network_inspectors/appid/test/appid_session_api_test.cc b/src/network_inspectors/appid/test/appid_session_api_test.cc
index 1a2fee5066a1a0038c9bf30045511b6c452ff5cb..c31b127c0d6fc0f5bfb4000cc69a8db6bde6c8aa 100644 (file)
--- a/src/network_inspectors/appid/test/appid_session_api_test.cc
+++ b/src/network_inspectors/appid/test/appid_session_api_test.cc
@@ -131,7 +131,8 @@ TEST(appid_session_api, get_service_port)
 TEST(appid_session_api, get_tls_host)
 {
     AppidChangeBits change_bits;
-    mock_session->tsession->set_tls_host(APPID_UT_TLS_HOST, 0, change_bits);
+    char* host = snort_strdup(APPID_UT_TLS_HOST);
+    mock_session->tsession->set_tls_host(host, 0, change_bits);
     const char* val = appid_session_api->get_tls_host();
     STRCMP_EQUAL(val, APPID_UT_TLS_HOST);
 }
@@ -384,7 +385,8 @@ TEST(appid_session_api, is_http_inspection_done)
     CHECK_FALSE(val);
     mock_session->service_disco_state = APPID_DISCO_STATE_STATEFUL;
     mock_session->set_session_flags(APPID_SESSION_SSL_SESSION);
-    mock_session->tsession->set_tls_host(APPID_UT_TLS_HOST, 0, change_bits);
+    char* host = snort_strdup(APPID_UT_TLS_HOST);
+    mock_session->tsession->set_tls_host(host, 0, change_bits);
     val = appid_session_api->is_http_inspection_done();
     CHECK_TRUE(val);
     mock_session->service_disco_state = APPID_DISCO_STATE_FINISHED;

diff --git a/src/network_inspectors/appid/tp_appid_utils.cc b/src/network_inspectors/appid/tp_appid_utils.cc
index d6be4c757b97b6a6c469240513cb963aef5c6836..77dbc112b995f1c5efcb0f0646f7fed8450fc531 100644 (file)
--- a/src/network_inspectors/appid/tp_appid_utils.cc
+++ b/src/network_inspectors/appid/tp_appid_utils.cc
@@ -441,14 +441,14 @@ static inline void process_ssl(AppIdSession& asd,
     asd.set_session_flags(APPID_SESSION_SSL_SESSION);
 
     if (!asd.tsession)
-        asd.tsession = (TlsSession*)snort_calloc(sizeof(TlsSession));
+        asd.tsession = new TlsSession();
 
     if (!asd.client.get_id())
         asd.set_client_appid_data(APP_ID_SSL_CLIENT, change_bits);
 
     reinspect_ssl_appid = check_ssl_appid_for_reinspect(tmpAppId, asd.ctxt.get_odp_ctxt());
 
-    if (!(asd.scan_flags & SCAN_DO_NOT_OVERRIDE_SERVER_NAME_FLAG) and
+    if (!(asd.scan_flags & SCAN_CERTVIZ_ENABLED_FLAG) and
         asd.tsession->get_tls_host() == nullptr and
         (field = attribute_data.tls_host(false)) != nullptr)
     {
@@ -457,7 +457,7 @@ static inline void process_ssl(AppIdSession& asd,
             asd.scan_flags |= SCAN_SSL_HOST_FLAG;
     }
 
-    if (!(asd.scan_flags & SCAN_DO_NOT_OVERRIDE_COMMON_NAME_FLAG) and
+    if (!(asd.scan_flags & SCAN_CERTVIZ_ENABLED_FLAG) and
         asd.tsession->get_tls_cname() == nullptr and
         (field = attribute_data.tls_cname()) != nullptr)
     {
@@ -468,7 +468,7 @@ static inline void process_ssl(AppIdSession& asd,
 
     if (reinspect_ssl_appid)
     {
-        if (!(asd.scan_flags & SCAN_DO_NOT_OVERRIDE_ORG_NAME_FLAG) and
+        if (!(asd.scan_flags & SCAN_CERTVIZ_ENABLED_FLAG) and
             asd.tsession->get_tls_org_unit() == nullptr and
             (field = attribute_data.tls_org_unit()) != nullptr)
         {
@@ -495,7 +495,7 @@ static inline void process_quic(AppIdSession& asd,
 {
     const string* field = 0;
     if ( !asd.tsession )
-        asd.tsession = (TlsSession*)snort_calloc(sizeof(TlsSession));
+        asd.tsession = new TlsSession();
 
     if ( (field=attribute_data.quic_sni()) != nullptr )
     {
@@ -784,7 +784,8 @@ bool do_tp_discovery(ThirdPartyAppIdContext& tp_appid_ctxt, AppIdSession& asd, I
             }
             else
             {
-                asd.set_tp_payload_app_id(*p, direction, tp_app_id, change_bits);
+                if (!(asd.scan_flags & SCAN_SPOOFED_SNI_FLAG))
+                    asd.set_tp_payload_app_id(*p, direction, tp_app_id, change_bits);
                 tp_app_id = portAppId;
                 if (appidDebug->is_active())
                 {