lib: o_stream_unix_write_fd() - Don't close fd on write failure

On success the write_fd is set to -1 without closing it, so the caller is
responsible for closing it.

If o_stream_unix_close() is reached with write_fd != -1, it means the write
failed. The write_fd shouldn't be closed in that case either.

This function wasn't actually currently used anywhere.

diff --git a/src/lib/ostream-unix.c b/src/lib/ostream-unix.c
index 06e918f3b28bff5f2602f17bda051844761e9be6..279913549a2dc128d1357e67c82b2e51177bcb20 100644 (file)
--- a/src/lib/ostream-unix.c
+++ b/src/lib/ostream-unix.c
@@ -13,11 +13,6 @@ struct unix_ostream {
 static void
 o_stream_unix_close(struct iostream_private *stream, bool close_parent)
 {
-       struct unix_ostream *ustream =
-               container_of(stream, struct unix_ostream,
-                            fstream.ostream.iostream);
-
-       i_close_fd(&ustream->write_fd);
        o_stream_file_close(stream, close_parent);
 }