prove: avoid weird signal-related bug

* tests/defs (trap): In the trap code dealing with SIGPIPE
signal, ignore further signals of the same kind.
See also Test::Harness issue [rt.cpan.org #70855], archived at
<https://rt.cpan.org/Ticket/Display.html?id=70855>

diff --git a/ChangeLog b/ChangeLog
index f4aa951c4b91e5f6b4828e3c3353b69f524ba86c..dbd588feeee0a2ef28239fed8d8066947f533afb 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2011-09-10  Stefano Lattarini  <stefano.lattarini@gmail.com>
+
+       prove: avoid weird signal-related bug
+       * tests/defs (trap): In the trap code dealing with SIGPIPE
+       signal, ignore further signals of the same kind.
+       See also Test::Harness issue [rt.cpan.org #70855], archived at
+       <https://rt.cpan.org/Ticket/Display.html?id=70855>
+
 2011-09-10  Stefano Lattarini  <stefano.lattarini@gmail.com>
 
        tests: allow use of `prove' to run automake testsuite

diff --git a/tests/defs b/tests/defs
index d50cb393a1593c6cd2e2e13ffcb24d88138d50eb..cf6db6924ad7d386151e321ba7c9adb4309e499f 100644 (file)
--- a/tests/defs
+++ b/tests/defs
@@ -944,10 +944,18 @@ if test "$sh_errexit_works" = yes; then
     echo "$me: exit $exit_status"
     exit $exit_status
   ' 0
-  for signal in 1 2 13 15; do
-    trap "fatal_ 'caught signal $signal'" $signal
-  done
-  unset signal
+  trap "fatal_ 'caught signal SIGHUP'" 1
+  trap "fatal_ 'caught signal SIGINIT'" 2
+  trap "fatal_ 'caught signal SIGTERM'" 15
+  # Ignore further SIGPIPE in the trap code.  This is required to avoid
+  # a very weird issue with some shells, at least when the execution of
+  # the automake testsuite is driven by the `prove' utility: if prove
+  # (or the make process that has spawned it) gets interrupted with
+  # Ctrl-C, the shell might go in a loop, continually getting a SIGPIPE,
+  # sometimes finally dumping core, other times hanging indefinitely.
+  # See also Test::Harness bug [rt.cpan.org #70855], archived at
+  # <https://rt.cpan.org/Ticket/Display.html?id=70855>
+  trap "trap '' 13; fatal_ 'caught signal SIGPIPE'" 13
 fi
 
 # Create and populate the temporary directory, if and as required.