audit: include source and destination ports to NETFILTER_PKT

NETFILTER_PKT records show both source and destination
addresses, in addition to the associated networking protocol.
However, it lacks the ports information, which is often
valuable for troubleshooting.

This patch adds both source and destination port numbers,
'sport' and 'dport' respectively, to TCP, UDP, UDP-Lite and
SCTP-related NETFILTER_PKT records.

 $ TESTS="netfilter_pkt" make -e test &> /dev/null
 $ ausearch -i -ts recent |grep NETFILTER_PKT
 type=NETFILTER_PKT ... proto=icmp
 type=NETFILTER_PKT ... proto=ipv6-icmp
 type=NETFILTER_PKT ... proto=udp sport=46333 dport=42424
 type=NETFILTER_PKT ... proto=udp sport=35953 dport=42424
 type=NETFILTER_PKT ... proto=tcp sport=50314 dport=42424
 type=NETFILTER_PKT ... proto=tcp sport=57346 dport=42424

Link: https://github.com/linux-audit/audit-kernel/issues/162
Signed-off-by: Ricardo Robaina <rrobaina@redhat.com>
Acked-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Paul Moore <paul@paul-moore.com>

diff --git a/kernel/audit.c b/kernel/audit.c
index 5c302c4592dbc7cd4ff92cd2d0443bf7c825dc40..39c4f26c484dcc2169049a63443a00d024eaf410 100644 (file)
--- a/kernel/audit.c
+++ b/kernel/audit.c
@@ -60,6 +60,7 @@
 #include <net/netns/generic.h>
 #include <net/ip.h>
 #include <net/ipv6.h>
+#include <linux/sctp.h>
 
 #include "audit.h"
 
@@ -2517,8 +2518,55 @@ int audit_log_nf_skb(struct audit_buffer *ab,
                if (!ih)
                        return -ENOMEM;
 
-               audit_log_format(ab, " saddr=%pI4 daddr=%pI4 proto=%hhu",
-                                &ih->saddr, &ih->daddr, ih->protocol);
+               switch (ih->protocol) {
+               case IPPROTO_TCP: {
+                       struct tcphdr _tcph;
+                       const struct tcphdr *th;
+
+                       th = skb_header_pointer(skb, skb_transport_offset(skb),
+                                               sizeof(_tcph), &_tcph);
+                       if (!th)
+                               return -ENOMEM;
+
+                       audit_log_format(ab, " saddr=%pI4 daddr=%pI4 proto=%hhu sport=%hu dport=%hu",
+                                        &ih->saddr, &ih->daddr, ih->protocol,
+                                        ntohs(th->source), ntohs(th->dest));
+                       break;
+               }
+               case IPPROTO_UDP:
+               case IPPROTO_UDPLITE: {
+                       struct udphdr _udph;
+                       const struct udphdr *uh;
+
+                       uh = skb_header_pointer(skb, skb_transport_offset(skb),
+                                               sizeof(_udph), &_udph);
+                       if (!uh)
+                               return -ENOMEM;
+
+                       audit_log_format(ab, " saddr=%pI4 daddr=%pI4 proto=%hhu sport=%hu dport=%hu",
+                                        &ih->saddr, &ih->daddr, ih->protocol,
+                                        ntohs(uh->source), ntohs(uh->dest));
+                       break;
+               }
+               case IPPROTO_SCTP: {
+                       struct sctphdr _sctph;
+                       const struct sctphdr *sh;
+
+                       sh = skb_header_pointer(skb, skb_transport_offset(skb),
+                                               sizeof(_sctph), &_sctph);
+                       if (!sh)
+                               return -ENOMEM;
+
+                       audit_log_format(ab, " saddr=%pI4 daddr=%pI4 proto=%hhu sport=%hu dport=%hu",
+                                        &ih->saddr, &ih->daddr, ih->protocol,
+                                        ntohs(sh->source), ntohs(sh->dest));
+                       break;
+               }
+               default:
+                       audit_log_format(ab, " saddr=%pI4 daddr=%pI4 proto=%hhu",
+                                        &ih->saddr, &ih->daddr, ih->protocol);
+               }
+
                break;
        }
        case NFPROTO_IPV6: {
@@ -2536,8 +2584,55 @@ int audit_log_nf_skb(struct audit_buffer *ab,
                ipv6_skip_exthdr(skb, skb_network_offset(skb) + sizeof(iph),
                                 &nexthdr, &frag_off);
 
-               audit_log_format(ab, " saddr=%pI6c daddr=%pI6c proto=%hhu",
-                                &ih->saddr, &ih->daddr, nexthdr);
+               switch (nexthdr) {
+               case IPPROTO_TCP: {
+                       struct tcphdr _tcph;
+                       const struct tcphdr *th;
+
+                       th = skb_header_pointer(skb, skb_transport_offset(skb),
+                                               sizeof(_tcph), &_tcph);
+                       if (!th)
+                               return -ENOMEM;
+
+                       audit_log_format(ab, " saddr=%pI6c daddr=%pI6c proto=%hhu sport=%hu dport=%hu",
+                                        &ih->saddr, &ih->daddr, nexthdr,
+                                        ntohs(th->source), ntohs(th->dest));
+                       break;
+               }
+               case IPPROTO_UDP:
+               case IPPROTO_UDPLITE: {
+                       struct udphdr _udph;
+                       const struct udphdr *uh;
+
+                       uh = skb_header_pointer(skb, skb_transport_offset(skb),
+                                               sizeof(_udph), &_udph);
+                       if (!uh)
+                               return -ENOMEM;
+
+                       audit_log_format(ab, " saddr=%pI6c daddr=%pI6c proto=%hhu sport=%hu dport=%hu",
+                                        &ih->saddr, &ih->daddr, nexthdr,
+                                        ntohs(uh->source), ntohs(uh->dest));
+                       break;
+               }
+               case IPPROTO_SCTP: {
+                       struct sctphdr _sctph;
+                       const struct sctphdr *sh;
+
+                       sh = skb_header_pointer(skb, skb_transport_offset(skb),
+                                               sizeof(_sctph), &_sctph);
+                       if (!sh)
+                               return -ENOMEM;
+
+                       audit_log_format(ab, " saddr=%pI6c daddr=%pI6c proto=%hhu sport=%hu dport=%hu",
+                                        &ih->saddr, &ih->daddr, nexthdr,
+                                        ntohs(sh->source), ntohs(sh->dest));
+                       break;
+               }
+               default:
+                       audit_log_format(ab, " saddr=%pI6c daddr=%pI6c proto=%hhu",
+                                        &ih->saddr, &ih->daddr, nexthdr);
+               }
+
                break;
        }
        default: