]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
Fortran: fix parsing of omp task affinity iterator clause [PR101330]
authorHarald Anlauf <anlauf@gmx.de>
Wed, 20 Jul 2022 18:40:23 +0000 (20:40 +0200)
committerHarald Anlauf <anlauf@gmx.de>
Wed, 20 Jul 2022 18:52:52 +0000 (20:52 +0200)
gcc/fortran/ChangeLog:

PR fortran/101330
* openmp.cc (gfc_match_iterator): Remove left-over code from
development that could lead to a crash on invalid input.

gcc/testsuite/ChangeLog:

PR fortran/101330
* gfortran.dg/gomp/affinity-clause-7.f90: New test.

(cherry picked from commit 26bbe78f77f73bb66af1ac13d0deec888a3c6510)

gcc/fortran/openmp.cc
gcc/testsuite/gfortran.dg/gomp/affinity-clause-7.f90 [new file with mode: 0644]

index 714148138c22468d10acb303aaeb2c9d374cc640..5018a37ec462627d7ed200d78f57745f2ee4d270 100644 (file)
@@ -1142,7 +1142,6 @@ gfc_match_iterator (gfc_namespace **ns, bool permit_var)
        }
       if (':' == gfc_peek_ascii_char ())
        {
-         step = gfc_get_expr ();
          if (gfc_match (": %e ", &step) != MATCH_YES)
            {
              gfc_free_expr (begin);
diff --git a/gcc/testsuite/gfortran.dg/gomp/affinity-clause-7.f90 b/gcc/testsuite/gfortran.dg/gomp/affinity-clause-7.f90
new file mode 100644 (file)
index 0000000..5b1ca85
--- /dev/null
@@ -0,0 +1,19 @@
+! { dg-do compile }
+! PR fortran/101330 - ICE in free_expr0(): Bad expr type
+! Contributed by G.Steinmetz
+
+  implicit none
+  integer :: j, b(10)
+!$omp task affinity (iterator(j=1:2:1) : b(j))
+!$omp end task
+!$omp task affinity (iterator(j=1:2:) : b(j)) ! { dg-error "Invalid character" }
+!!$omp end task
+!$omp task affinity (iterator(j=1:2:          ! { dg-error "Invalid character" }
+!!$omp end task
+!$omp task affinity (iterator(j=1:2:)         ! { dg-error "Invalid character" }
+!!$omp end task
+!$omp task affinity (iterator(j=1:2::)        ! { dg-error "Invalid character" }
+!!$omp end task
+!$omp task affinity (iterator(j=1:2:))        ! { dg-error "Invalid character" }
+!!$omp end task
+end