]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
cpufreq: simplify setpolicy/target check in driver verification
authorZihuan Zhang <zhangzihuan@kylinos.cn>
Fri, 22 Aug 2025 07:04:24 +0000 (15:04 +0800)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Fri, 22 Aug 2025 19:33:22 +0000 (21:33 +0200)
cpufreq drivers are supposed to use either ->setpolicy() or
->target()/->target_index().

Simplify the existing check by collapsing it into a single boolean
expression:

    (!!driver->setpolicy == (driver->target_index || driver->target))

This is a readability/maintainability cleanup and keeps the semantics
unchanged.

No functional change intended.

Signed-off-by: Zihuan Zhang <zhangzihuan@kylinos.cn>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Link: https://patch.msgid.link/20250822070424.166795-3-zhangzihuan@kylinos.cn
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/cpufreq/cpufreq.c

index d337f94f70a388311b620d1c75802968e37416c2..a615c98d80ca0182518d4f2118fb89e5082195e7 100644 (file)
@@ -2922,10 +2922,7 @@ int cpufreq_register_driver(struct cpufreq_driver *driver_data)
                return -EPROBE_DEFER;
 
        if (!driver_data || !driver_data->verify || !driver_data->init ||
-           !(driver_data->setpolicy || driver_data->target_index ||
-                   driver_data->target) ||
-            (driver_data->setpolicy && (driver_data->target_index ||
-                   driver_data->target)) ||
+            (!!driver_data->setpolicy == (driver_data->target_index || driver_data->target)) ||
             (!driver_data->get_intermediate != !driver_data->target_intermediate) ||
             (!driver_data->online != !driver_data->offline) ||
                 (driver_data->adjust_perf && !driver_data->fast_switch))