]> git.ipfire.org Git - thirdparty/krb5.git/commitdiff
Fix leak in FAST OTP client processing
authorGreg Hudson <ghudson@mit.edu>
Wed, 29 Jun 2016 01:38:57 +0000 (21:38 -0400)
committerTom Yu <tlyu@mit.edu>
Fri, 2 Sep 2016 22:30:08 +0000 (18:30 -0400)
In set_pa_data(), after encoding the OTP request and stealing the
pointer from the resulting krb5_data object, free the krb5_data
container.

(cherry picked from commit 7029efc11525299b87b9024280ef1d9f82059ec5)

ticket: 8443
version_fixed: 1.13.7

src/lib/krb5/krb/preauth_otp.c

index 3de528b5ae19b5d8747e83cb1483151d87db2f5a..37f98b2924eda327e08ad3d8a2f6dc01bf697494 100644 (file)
@@ -830,6 +830,7 @@ set_pa_data(const krb5_pa_otp_req *req, krb5_pa_data ***pa_data_out)
         goto error;
     out[0]->contents = (krb5_octet *)tmp->data;
     out[0]->length = tmp->length;
+    free(tmp);
 
     *pa_data_out = out;
     return 0;