[Backport r51224 | neal.norwitz]

Move the assert which checks for a NULL pointer first.
Klocwork #274.

diff --git a/Modules/collectionsmodule.c b/Modules/collectionsmodule.c
index 4457551bb0a9ea2bd70cb67e86e17ebaa6402764..3387b99365f6c5798209f28dbecc579bf9b4a6ec 100644 (file)
--- a/Modules/collectionsmodule.c
+++ b/Modules/collectionsmodule.c
@@ -225,9 +225,9 @@ deque_popleft(dequeobject *deque, PyObject *unused)
                        deque->leftindex = CENTER + 1;
                        deque->rightindex = CENTER;
                } else {
+                       assert(deque->leftblock != NULL);
                        assert(deque->leftblock != deque->rightblock);
                        prevblock = deque->leftblock->rightlink;
-                       assert(deque->leftblock != NULL);
                        PyMem_Free(deque->leftblock);
                        assert(prevblock != NULL);
                        prevblock->leftlink = NULL;