]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
selftests: ptp: use KSFT_SKIP exit code for skip scenarios
authorJunjie Cao <junjie.cao@intel.com>
Mon, 26 Jan 2026 06:15:31 +0000 (14:15 +0800)
committerJakub Kicinski <kuba@kernel.org>
Wed, 28 Jan 2026 01:57:28 +0000 (17:57 -0800)
The kselftest framework defines KSFT_SKIP=4 as the standard exit code
for skipped tests. However, phc.sh currently uses a mix of 'exit 0' and
'exit 1' to indicate skip conditions, which can confuse test harnesses
and CI systems.

This patch introduces ksft_skip=4 variable and unifies all skip exit
paths to use 'exit $ksft_skip', consistent with other selftests like
net/lib.sh and net/fib_nexthops.sh.

Signed-off-by: Junjie Cao <junjie.cao@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20260126061532.12532-1-junjie.cao@intel.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/testing/selftests/ptp/phc.sh

index ac6e5a6e1d3ad331dc3bf4e39fece4e3062e3e15..51aad466d989d2ce9077247059004db3d5c3ed95 100755 (executable)
@@ -8,17 +8,20 @@ ALL_TESTS="
 "
 DEV=$1
 
+# Kselftest framework requirement - SKIP code is 4.
+ksft_skip=4
+
 ##############################################################################
 # Sanity checks
 
 if [[ "$(id -u)" -ne 0 ]]; then
        echo "SKIP: need root privileges"
-       exit 0
+       exit $ksft_skip
 fi
 
 if [[ "$DEV" == "" ]]; then
        echo "SKIP: PTP device not provided"
-       exit 0
+       exit $ksft_skip
 fi
 
 require_command()
@@ -27,7 +30,7 @@ require_command()
 
        if [[ ! -x "$(command -v "$cmd")" ]]; then
                echo "SKIP: $cmd not installed"
-               exit 1
+               exit $ksft_skip
        fi
 }
 
@@ -37,7 +40,7 @@ phc_sanity()
 
        if [ $? != 0 ]; then
                echo "SKIP: unknown clock $DEV: No such device"
-               exit 1
+               exit $ksft_skip
        fi
 }