detect: checks for overflow when comparing signatures priorities

diff --git a/src/detect-engine-sigorder.c b/src/detect-engine-sigorder.c
index 6cfa2d9e8aaf46ec47131ffd9450d6a6da55215d..469af1f60b82b8b67074f947e66d2713de1b7d1f 100644 (file)
--- a/src/detect-engine-sigorder.c
+++ b/src/detect-engine-sigorder.c
@@ -682,7 +682,12 @@ static int SCSigOrderByIPPairbitsCompare(SCSigSignatureWrapper *sw1,
 static int SCSigOrderByPriorityCompare(SCSigSignatureWrapper *sw1,
                                        SCSigSignatureWrapper *sw2)
 {
-    return sw2->sig->prio - sw1->sig->prio;
+    if (sw1->sig->prio > sw2->sig->prio) {
+        return -1;
+    } else if (sw1->sig->prio < sw2->sig->prio) {
+        return 1;
+    }
+    return 0;
 }
 
 /**