]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
pcap-log: fix path construct check
authorVictor Julien <victor@inliniac.net>
Thu, 13 Jul 2017 06:51:30 +0000 (08:51 +0200)
committerVictor Julien <victor@inliniac.net>
Thu, 13 Jul 2017 06:51:30 +0000 (08:51 +0200)
src/log-pcap.c

index 758e1e695078e16f5588519e1761b97e2f5a87ab..cd8acc164b723d30ba7090a885c601e6b2abd3a7 100644 (file)
@@ -1254,7 +1254,7 @@ static int PcapLogOpenFileCtx(PcapLogData *pl)
             ret = snprintf(filename, PATH_MAX, "%s/%s.%" PRIu32 ".%" PRIu32, pl->dir,
                     pl->prefix, (uint32_t)ts.tv_sec, (uint32_t)ts.tv_usec);
         }
-        if (ret < 0 || (size_t)ret >= sizeof(filename)) {
+        if (ret < 0 || (size_t)ret >= PATH_MAX) {
             SCLogError(SC_ERR_SPRINTF,"failed to construct path");
             goto error;
         }
@@ -1312,7 +1312,7 @@ static int PcapLogOpenFileCtx(PcapLogData *pl)
                 ret = snprintf(filename, PATH_MAX, "%s/%s.%u.%" PRIu32 ".%" PRIu32, pl->dir,
                         pl->prefix, pl->thread_number, (uint32_t)ts.tv_sec, (uint32_t)ts.tv_usec);
             }
-            if (ret < 0 || (size_t)ret >= sizeof(filename)) {
+            if (ret < 0 || (size_t)ret >= PATH_MAX) {
                 SCLogError(SC_ERR_SPRINTF,"failed to construct path");
                 goto error;
             }