]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
gimplefe: Error recovery for invalid declarations [PR117749]
authorAndrew Pinski <quic_apinski@quicinc.com>
Fri, 29 Nov 2024 23:29:41 +0000 (15:29 -0800)
committerAndrew Pinski <quic_apinski@quicinc.com>
Sat, 30 Nov 2024 07:11:49 +0000 (23:11 -0800)
c_parser_declarator can return null if there was an error,
but c_parser_gimple_declaration was not ready for that.
This fixes that oversight so we don't get an ICE after the error.

Bootstrapped and tested on x86_64-linux-gnu.

PR c/117749

gcc/c/ChangeLog:

* gimple-parser.cc (c_parser_gimple_declaration): Check
declarator to be non-null.

gcc/testsuite/ChangeLog:

* gcc.dg/gimplefe-55.c: New test.

Signed-off-by: Andrew Pinski <quic_apinski@quicinc.com>
gcc/c/gimple-parser.cc
gcc/testsuite/gcc.dg/gimplefe-55.c [new file with mode: 0644]

index 4763cf23313b8c531d37fd860f71942a3f04a073..78e85d934879c4923e6606f62abc9353d573f080 100644 (file)
@@ -2208,7 +2208,12 @@ c_parser_gimple_declaration (gimple_parser &parser)
                                    specs->typespec_kind != ctsk_none,
                                    C_DTR_NORMAL, &dummy);
 
-  if (c_parser_next_token_is (parser, CPP_SEMICOLON))
+  if (!c_parser_next_token_is (parser, CPP_SEMICOLON))
+    {
+      c_parser_error (parser, "expected %<;%>");
+      return;
+    }
+  if (declarator)
     {
       /* Handle SSA name decls specially, they do not go into the identifier
          table but we simply build the SSA name for later lookup.  */
@@ -2253,11 +2258,6 @@ c_parser_gimple_declaration (gimple_parser &parser)
                         NULL_TREE);
        }
     }
-  else
-    {
-      c_parser_error (parser, "expected %<;%>");
-      return;
-    }
 }
 
 /* Parse gimple goto statement.  */
diff --git a/gcc/testsuite/gcc.dg/gimplefe-55.c b/gcc/testsuite/gcc.dg/gimplefe-55.c
new file mode 100644 (file)
index 0000000..120f4ec
--- /dev/null
@@ -0,0 +1,11 @@
+/* { dg-do compile } */
+/* { dg-options "-fgimple" } */
+
+/* PR c/117749 */
+/* Make sure we don't ICE after not have a full local
+   declaration in gimple fe. */
+
+__GIMPLE
+void foo ( ) {
+  int ;  /* { dg-error "" } */
+}