platform/surface: Replace deprecated strcpy() in surface_button_add()

strcpy() has been deprecated [1] because it performs no bounds checking
on the destination buffer, which can lead to buffer overflows. Replace
it with the safer strscpy().  No functional changes.

Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy
Reviewed-by: Chen Yu <yu.c.chen@intel.com>
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Link: https://patch.msgid.link/20260105145045.52764-2-thorsten.blum@linux.dev
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

diff --git a/drivers/platform/surface/surfacepro3_button.c b/drivers/platform/surface/surfacepro3_button.c
index 2755601f979cd53a4618bc6874f946fbd2f9dcc7..e652c85c91616f119cfa9556d28ad6b4ccf03b2b 100644 (file)
--- a/drivers/platform/surface/surfacepro3_button.c
+++ b/drivers/platform/surface/surfacepro3_button.c
@@ -10,6 +10,7 @@
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/init.h>
+#include <linux/string.h>
 #include <linux/types.h>
 #include <linux/input.h>
 #include <linux/acpi.h>
@@ -189,7 +190,6 @@ static int surface_button_add(struct acpi_device *device)
        struct surface_button *button;
        struct input_dev *input;
        const char *hid = acpi_device_hid(device);
-       char *name;
        int error;
 
        if (strncmp(acpi_device_bid(device), SURFACE_BUTTON_OBJ_NAME,
@@ -210,11 +210,10 @@ static int surface_button_add(struct acpi_device *device)
                goto err_free_button;
        }
 
-       name = acpi_device_name(device);
-       strcpy(name, SURFACE_BUTTON_DEVICE_NAME);
+       strscpy(acpi_device_name(device), SURFACE_BUTTON_DEVICE_NAME);
        snprintf(button->phys, sizeof(button->phys), "%s/buttons", hid);
 
-       input->name = name;
+       input->name = acpi_device_name(device);
        input->phys = button->phys;
        input->id.bustype = BUS_HOST;
        input->dev.parent = &device->dev;
@@ -228,8 +227,8 @@ static int surface_button_add(struct acpi_device *device)
                goto err_free_input;
 
        device_init_wakeup(&device->dev, true);
-       dev_info(&device->dev,
-                       "%s [%s]\n", name, acpi_device_bid(device));
+       dev_info(&device->dev, "%s [%s]\n", acpi_device_name(device),
+                acpi_device_bid(device));
        return 0;
 
  err_free_input: