]> git.ipfire.org Git - thirdparty/bootstrap.git/commitdiff
use `:read-only` css selector instead `[readonly]` for consistency (#33642)
authorharishhalodoc <80090779+harishhalodoc@users.noreply.github.com>
Sat, 17 Apr 2021 21:33:27 +0000 (03:03 +0530)
committerGitHub <noreply@github.com>
Sat, 17 Apr 2021 21:33:27 +0000 (14:33 -0700)
There are 5 places where [readonly] selector is used. I have replaced with :read-only for consistency.

fix for https://github.com/twbs/bootstrap/issues/33101

Co-authored-by: Harish <halodoc@ip-192-168-43-211.ap-southeast-1.compute.internal>
scss/forms/_form-control.scss

index 9728b91f3471b347afaf1ca7453ff2b25fd67c09..5e43aea991127403803b7cab0e2931d6dcfc8b5a 100644 (file)
@@ -25,7 +25,7 @@
   &[type="file"] {
     overflow: hidden; // prevent pseudo element button overlap
 
-    &:not(:disabled):not([readonly]) {
+    &:not(:disabled):not(:read-only) {
       cursor: pointer;
     }
   }
@@ -65,7 +65,7 @@
   // disabled if the fieldset is disabled. Due to implementation difficulty, we
   // don't honor that edge case; we style them as disabled anyway.
   &:disabled,
-  &[readonly] {
+  &:read-only {
     background-color: $input-disabled-bg;
     border-color: $input-disabled-border-color;
     // iOS fix for unreadable disabled content; see https://github.com/twbs/bootstrap/issues/11655.
@@ -88,7 +88,7 @@
     @include transition($btn-transition);
   }
 
-  &:hover:not(:disabled):not([readonly])::file-selector-button {
+  &:hover:not(:disabled):not(:read-only)::file-selector-button {
     background-color: $form-file-button-hover-bg;
   }
 
     @include transition($btn-transition);
   }
 
-  &:hover:not(:disabled):not([readonly])::-webkit-file-upload-button {
+  &:hover:not(:disabled):not(:read-only)::-webkit-file-upload-button {
     background-color: $form-file-button-hover-bg;
   }
 }
@@ -203,7 +203,7 @@ textarea {
   height: auto; // Override fixed browser height
   padding: $input-padding-y;
 
-  &:not(:disabled):not([readonly]) {
+  &:not(:disabled):not(:read-only) {
     cursor: pointer;
   }