detect: fix port parsing memory leak

Leak in error path as seen by scan-build:

  CC       detect-engine-port.o
detect-engine-port.c:1083:13: warning: Potential leak of memory pointed to by 'temp_rule_var_port'
    return -1;
            ^

diff --git a/src/detect-engine-port.c b/src/detect-engine-port.c
index db0ab8354f3127eb69803467148764c99a11b9d8..72f28c599eca49eb646d297f72e3acb7a3b849d4 100644 (file)
--- a/src/detect-engine-port.c
+++ b/src/detect-engine-port.c
@@ -977,9 +977,10 @@ static int DetectPortParseDo(const DetectEngineCtx *de_ctx,
                 temp_rule_var_port = alloc_rule_var_port;
                 r = DetectPortParseDo(de_ctx, head, nhead, temp_rule_var_port,
                                   (negate + n_set) % 2, var_list);//negate? negate: n_set);
-                if (r == -1)
+                if (r == -1) {
+                    SCFree(alloc_rule_var_port);
                     goto error;
-
+                }
                 d_set = 0;
                 n_set = 0;
                 SCFree(alloc_rule_var_port);