]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
binder: fix BR_FROZEN_REPLY error log
authorCarlos Llamas <cmllamas@google.com>
Fri, 23 Jan 2026 17:57:02 +0000 (17:57 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 26 Jan 2026 15:30:07 +0000 (16:30 +0100)
The error logging for failed transactions is misleading as it always
reports "dead process or thread" even when the target is actually
frozen. Additionally, the pid and tid are reversed which can further
confuse debugging efforts. Fix both issues.

Cc: stable@kernel.org
Cc: Steven Moreland <smoreland@google.com>
Fixes: a15dac8b2286 ("binder: additional transaction error logs")
Signed-off-by: Carlos Llamas <cmllamas@google.com>
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
Link: https://patch.msgid.link/20260123175702.2154348-1-cmllamas@google.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/android/binder.c

index 4e16438eceb70252f405712cf1f20102fddea834..b356c9b882544fb0ad25039571ac7b11bb5c1366 100644 (file)
@@ -3824,8 +3824,9 @@ static void binder_transaction(struct binder_proc *proc,
        return;
 
 err_dead_proc_or_thread:
-       binder_txn_error("%d:%d dead process or thread\n",
-               thread->pid, proc->pid);
+       binder_txn_error("%d:%d %s process or thread\n",
+                        proc->pid, thread->pid,
+                        return_error == BR_FROZEN_REPLY ? "frozen" : "dead");
        return_error_line = __LINE__;
        binder_dequeue_work(proc, tcomplete);
 err_translate_failed: