]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
arm64: dts: qcom: sm8250: fix USB-DP PHY registers
authorJohan Hovold <johan+linaro@kernel.org>
Fri, 11 Nov 2022 09:47:29 +0000 (10:47 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 31 Dec 2022 12:26:51 +0000 (13:26 +0100)
commit f8d8840c72b3df61b5252052b79020dabec01ab5 upstream.

When adding support for the DisplayPort part of the QMP PHY the binding
(and devicetree parser) for the (USB) child node was simply reused and
this has lead to some confusion.

The third DP register region is really the DP_PHY region, not "PCS" as
the binding claims, and lie at offset 0x2a00 (not 0x2c00).

Similarly, there likely are no "RX", "RX2" or "PCS_MISC" regions as
there are for the USB part of the PHY (and in any case the Linux driver
does not use them).

Note that the sixth "PCS_MISC" region is not even in the binding.

Fixes: 5aa0d1becd5b ("arm64: dts: qcom: sm8250: switch usb1 qmp phy to USB3+DP mode")
Cc: stable@vger.kernel.org # 5.13
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
Link: https://lore.kernel.org/r/20221111094729.11842-3-johan+linaro@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/arm64/boot/dts/qcom/sm8250.dtsi

index ab6c4c3543384e7ec2df41ba77a68c520fd2bda9..652fb0231da0e55d519e758ffefe1e4cb60c968c 100644 (file)
                        dp_phy: dp-phy@88ea200 {
                                reg = <0 0x088ea200 0 0x200>,
                                      <0 0x088ea400 0 0x200>,
-                                     <0 0x088eac00 0 0x400>,
+                                     <0 0x088eaa00 0 0x200>,
                                      <0 0x088ea600 0 0x200>,
-                                     <0 0x088ea800 0 0x200>,
-                                     <0 0x088eaa00 0 0x100>;
+                                     <0 0x088ea800 0 0x200>;
                                #phy-cells = <0>;
                                #clock-cells = <1>;
                        };