]> git.ipfire.org Git - thirdparty/Chart.js.git/commitdiff
platform.isAttached should return false if canvas is false-y (#11707)
authorArun Philip <dacodedbeat@gmail.com>
Mon, 11 Mar 2024 08:57:07 +0000 (04:57 -0400)
committerGitHub <noreply@github.com>
Mon, 11 Mar 2024 08:57:07 +0000 (09:57 +0100)
* platform.isAttached should return false if canvas is false-y

* change styling to conform to codeclimate linter

src/helpers/helpers.dom.ts
src/platform/platform.dom.js

index c83712983acab6ee6451645a7e085b9829ca86a4..e06fefe94a6680c82ea645dbc7dd47a3c0bc3b82 100644 (file)
@@ -142,7 +142,7 @@ function getContainerSize(canvas: HTMLCanvasElement, width: number, height: numb
   let maxWidth: number, maxHeight: number;
 
   if (width === undefined || height === undefined) {
-    const container = _getParentNode(canvas);
+    const container = canvas && _getParentNode(canvas);
     if (!container) {
       width = canvas.clientWidth;
       height = canvas.clientHeight;
index 6c4b96d7546e35231cd7e52633cfe4243ee2c0eb..4c6f72e425e18a6a9ff3405b5c2e7ea3f56e418c 100644 (file)
@@ -383,7 +383,7 @@ export default class DomPlatform extends BasePlatform {
         * @param {HTMLCanvasElement} canvas
         */
   isAttached(canvas) {
-    const container = _getParentNode(canvas);
+    const container = canvas && _getParentNode(canvas);
     return !!(container && container.isConnected);
   }
 }