]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
Revert "qemu: Validate MTE feature"
authorAndrea Bolognani <abologna@redhat.com>
Mon, 22 May 2023 07:49:51 +0000 (09:49 +0200)
committerAndrea Bolognani <abologna@redhat.com>
Mon, 22 May 2023 13:13:17 +0000 (15:13 +0200)
The QEMU interface is still in a state of flux, and KVM support
has been pulled shortly after having been merged. Let's not
commit to a stable interface in libvirt just yet.

Reverts: c6c9b5d251de215ed378aa0bc31daa2e1170409e
Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
src/qemu/qemu_validate.c

index da765568544d55a41a36b32681ae6837ab96f71f..99c7775e9bf11c247b6f341e7799fabfc8a132a4 100644 (file)
@@ -124,23 +124,14 @@ qemuValidateDomainDefFeatures(const virDomainDef *def,
 
         case VIR_DOMAIN_FEATURE_GIC:
         case VIR_DOMAIN_FEATURE_MTE:
-            if (def->features[i] != VIR_TRISTATE_SWITCH_ABSENT) {
-                if (!qemuDomainIsARMVirt(def)) {
-                    virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
-                                   _("The '%1$s' feature is not supported for architecture '%2$s' or machine type '%3$s'"),
-                                   featureName,
-                                   virArchToString(def->os.arch),
-                                   def->os.machine);
-                    return -1;
-                }
-
-                if (i == VIR_DOMAIN_FEATURE_MTE &&
-                    !virQEMUCapsGet(qemuCaps, QEMU_CAPS_MACHINE_VIRT_MTE)) {
-                    virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
-                                   _("The '%1$s' feature is not supported with this QEMU binary"),
-                                   featureName);
-                    return -1;
-                }
+            if (def->features[i] == VIR_TRISTATE_SWITCH_ON &&
+                !qemuDomainIsARMVirt(def)) {
+                virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
+                               _("The '%1$s' feature is not supported for architecture '%2$s' or machine type '%3$s'"),
+                               featureName,
+                               virArchToString(def->os.arch),
+                               def->os.machine);
+                return -1;
             }
             break;