]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
pinctrl: qcom: lpass-lpi: use new GPIO line value setter callbacks
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Thu, 10 Apr 2025 09:34:43 +0000 (11:34 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Thu, 17 Apr 2025 07:39:15 +0000 (09:39 +0200)
struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://lore.kernel.org/20250410-gpiochip-set-rv-pinctrl-qcom-v1-1-6a6891338aae@linaro.org
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/qcom/pinctrl-lpass-lpi.c

index 7366aba5a199b46bab7d722856ee30f5dc7ff72b..57fefeb603f0e2502fccd14ba3982ae3cb591978 100644 (file)
@@ -327,14 +327,14 @@ static int lpi_gpio_get(struct gpio_chip *chip, unsigned int pin)
                LPI_GPIO_VALUE_IN_MASK;
 }
 
-static void lpi_gpio_set(struct gpio_chip *chip, unsigned int pin, int value)
+static int lpi_gpio_set(struct gpio_chip *chip, unsigned int pin, int value)
 {
        struct lpi_pinctrl *state = gpiochip_get_data(chip);
        unsigned long config;
 
        config = pinconf_to_config_packed(PIN_CONFIG_OUTPUT, value);
 
-       lpi_config_set(state->ctrl, pin, &config, 1);
+       return lpi_config_set(state->ctrl, pin, &config, 1);
 }
 
 #ifdef CONFIG_DEBUG_FS
@@ -398,7 +398,7 @@ static const struct gpio_chip lpi_gpio_template = {
        .direction_input        = lpi_gpio_direction_input,
        .direction_output       = lpi_gpio_direction_output,
        .get                    = lpi_gpio_get,
-       .set                    = lpi_gpio_set,
+       .set_rv                 = lpi_gpio_set,
        .request                = gpiochip_generic_request,
        .free                   = gpiochip_generic_free,
        .dbg_show               = lpi_gpio_dbg_show,