]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemuxml2xmltest: Modernize iothread CWW/SCSI test cases
authorPeter Krempa <pkrempa@redhat.com>
Wed, 22 Feb 2023 14:37:52 +0000 (15:37 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Mon, 6 Mar 2023 12:22:36 +0000 (13:22 +0100)
The argv counterparts are already modernized.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
tests/qemuxml2xmloutdata/iothreads-disk-virtio-ccw.s390x-latest.xml [moved from tests/qemuxml2xmloutdata/iothreads-disk-virtio-ccw.xml with 89% similarity]
tests/qemuxml2xmloutdata/iothreads-virtio-scsi-ccw.s390x-latest.xml [moved from tests/qemuxml2xmloutdata/iothreads-virtio-scsi-ccw.xml with 90% similarity]
tests/qemuxml2xmloutdata/iothreads-virtio-scsi-pci.x86_64-latest.xml [moved from tests/qemuxml2xmloutdata/iothreads-virtio-scsi-pci.xml with 92% similarity]
tests/qemuxml2xmltest.c

similarity index 89%
rename from tests/qemuxml2xmloutdata/iothreads-disk-virtio-ccw.xml
rename to tests/qemuxml2xmloutdata/iothreads-disk-virtio-ccw.s390x-latest.xml
index 05cb204ea5703e99e4a992c471921ee5ca4d3f20..cdcee3bbb4a4aadcb3d9d0043d7827d43b823027 100644 (file)
@@ -9,6 +9,9 @@
     <type arch='s390x' machine='s390-ccw-virtio'>hvm</type>
     <boot dev='hd'/>
   </os>
+  <cpu mode='custom' match='exact' check='none'>
+    <model fallback='forbid'>qemu</model>
+  </cpu>
   <clock offset='utc'/>
   <on_poweroff>destroy</on_poweroff>
   <on_reboot>restart</on_reboot>
@@ -28,6 +31,7 @@
       <address type='ccw' cssid='0x0' ssid='0x0' devno='0x0007'/>
     </disk>
     <controller type='usb' index='0' model='none'/>
+    <controller type='pci' index='0' model='pci-root'/>
     <audio id='1' type='none'/>
     <memballoon model='virtio'>
       <address type='ccw' cssid='0xfe' ssid='0x0' devno='0x000a'/>
similarity index 90%
rename from tests/qemuxml2xmloutdata/iothreads-virtio-scsi-ccw.xml
rename to tests/qemuxml2xmloutdata/iothreads-virtio-scsi-ccw.s390x-latest.xml
index 11fead6c8be204b10a782d021a684a3f5c0edcd8..d73f43f2350f65e156c22a5f12f07c9608a82f8e 100644 (file)
@@ -9,6 +9,9 @@
     <type arch='s390x' machine='s390-ccw-virtio'>hvm</type>
     <boot dev='hd'/>
   </os>
+  <cpu mode='custom' match='exact' check='none'>
+    <model fallback='forbid'>qemu</model>
+  </cpu>
   <clock offset='utc'/>
   <on_poweroff>destroy</on_poweroff>
   <on_reboot>restart</on_reboot>
@@ -32,6 +35,7 @@
       <driver iothread='2'/>
       <address type='ccw' cssid='0xfe' ssid='0x0' devno='0x0001'/>
     </controller>
+    <controller type='pci' index='0' model='pci-root'/>
     <audio id='1' type='none'/>
     <memballoon model='virtio'>
       <address type='ccw' cssid='0xfe' ssid='0x0' devno='0x000a'/>
similarity index 92%
rename from tests/qemuxml2xmloutdata/iothreads-virtio-scsi-pci.xml
rename to tests/qemuxml2xmloutdata/iothreads-virtio-scsi-pci.x86_64-latest.xml
index b2c66ba9b861bd767f8d199aef9b638570aac89d..5418a38a394a96a400eadc5c7f5676de74e8fa7e 100644 (file)
@@ -9,6 +9,9 @@
     <type arch='x86_64' machine='pc'>hvm</type>
     <boot dev='hd'/>
   </os>
+  <cpu mode='custom' match='exact' check='none'>
+    <model fallback='forbid'>qemu64</model>
+  </cpu>
   <clock offset='utc'/>
   <on_poweroff>destroy</on_poweroff>
   <on_reboot>restart</on_reboot>
@@ -33,7 +36,7 @@
       <target dev='sdc' bus='scsi'/>
       <address type='drive' controller='0' bus='0' target='0' unit='3'/>
     </disk>
-    <controller type='usb' index='0'>
+    <controller type='usb' index='0' model='piix3-uhci'>
       <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x2'/>
     </controller>
     <controller type='ide' index='0'>
index 357d91a4802965b9496c6935b68ecfcfab34dd78..0bc757c335b805d1608fc84388f31d09eaee08e3 100644 (file)
@@ -577,11 +577,9 @@ mymain(void)
     DO_TEST_CAPS_LATEST("iothreads-ids-partial");
     DO_TEST_NOCAPS("cputune-iothreads");
     DO_TEST_CAPS_LATEST("iothreads-disk");
-    DO_TEST_NOCAPS("iothreads-disk-virtio-ccw");
-    DO_TEST("iothreads-virtio-scsi-pci",
-            QEMU_CAPS_VIRTIO_SCSI);
-    DO_TEST("iothreads-virtio-scsi-ccw",
-            QEMU_CAPS_VIRTIO_SCSI);
+    DO_TEST_CAPS_ARCH_LATEST("iothreads-disk-virtio-ccw", "s390x");
+    DO_TEST_CAPS_LATEST("iothreads-virtio-scsi-pci");
+    DO_TEST_CAPS_ARCH_LATEST("iothreads-virtio-scsi-ccw", "s390x");
     DO_TEST_NOCAPS("lease");
     DO_TEST_NOCAPS("event_idx");
     DO_TEST_NOCAPS("vhost_queues");