]> git.ipfire.org Git - thirdparty/apache/httpd.git/commitdiff
Backports: r1483005
authorWilliam A. Rowe Jr <wrowe@apache.org>
Thu, 22 Dec 2016 22:57:41 +0000 (22:57 +0000)
committerWilliam A. Rowe Jr <wrowe@apache.org>
Thu, 22 Dec 2016 22:57:41 +0000 (22:57 +0000)
Submitted by: jailletc36
core: Do not over allocate memory within 'ap_rgetline_core' for the common case.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.2.x-merge-http-strict@1775767 13f79535-47bb-0310-9956-ffa450edef68

server/protocol.c

index 76c15838484fbc525cdd4df7a2d0368ec20c17c3..6876c0a4f9998ab5900f6f2e6a801dd7b931bae9 100644 (file)
@@ -183,9 +183,6 @@ AP_DECLARE(apr_time_t) ap_rationalize_mtime(request_rec *r, apr_time_t mtime)
     return (mtime > now) ? now : mtime;
 }
 
-/* Min # of bytes to allocate when reading a request line */
-#define MIN_LINE_ALLOC 80
-
 /* Get a line of protocol input, including any continuation lines
  * caused by MIME folding (or broken clients) if fold != 0, and place it
  * in the buffer s, of size n bytes, without the ending newline.
@@ -284,9 +281,6 @@ AP_DECLARE(apr_status_t) ap_rgetline_core(char **s, apr_size_t n,
                 /* We'll assume the common case where one bucket is enough. */
                 if (!*s) {
                     current_alloc = len;
-                    if (current_alloc < MIN_LINE_ALLOC) {
-                        current_alloc = MIN_LINE_ALLOC;
-                    }
                     *s = apr_palloc(r->pool, current_alloc);
                 }
                 else if (bytes_handled + len > current_alloc) {