]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
i2c: qcom-cci: Do not check return value of cci_init()
authorVladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Fri, 15 May 2026 23:41:19 +0000 (02:41 +0300)
committerAndi Shyti <andi.shyti@kernel.org>
Tue, 16 Jun 2026 12:39:56 +0000 (14:39 +0200)
The cci_init() function is not supposed to fail, and it never returns
a non-zero, so it'd make sense to convert its signature to void.

Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Reviewed-by: Loic Poulain <loic.poulain@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
Link: https://lore.kernel.org/r/20260515234121.1607425-3-vladimir.zapolskiy@linaro.org
drivers/i2c/busses/i2c-qcom-cci.c

index 01e440b6585dbb7ee31fa89afd6aee13ed5847d9..be41a53e30c6379f9a8aee004c21804b4aeb85a9 100644 (file)
@@ -243,7 +243,7 @@ static int cci_reset(struct cci *cci)
        return 0;
 }
 
-static int cci_init(struct cci *cci)
+static void cci_init(struct cci *cci)
 {
        u32 val = CCI_IRQ_MASK_0_I2C_M0_RD_DONE |
                        CCI_IRQ_MASK_0_I2C_M0_Q0_REPORT |
@@ -284,8 +284,6 @@ static int cci_init(struct cci *cci)
                val = hw->scl_stretch_en << 8 | hw->trdhld << 4 | hw->tsp;
                writel(val, cci->base + CCI_I2C_Mm_MISC_CTL(i));
        }
-
-       return 0;
 }
 
 static int cci_run_queue(struct cci *cci, u8 master, u8 queue)
@@ -611,9 +609,7 @@ static int cci_probe(struct platform_device *pdev)
        if (ret < 0)
                goto error;
 
-       ret = cci_init(cci);
-       if (ret < 0)
-               goto error;
+       cci_init(cci);
 
        pm_runtime_set_autosuspend_delay(dev, MSEC_PER_SEC);
        pm_runtime_use_autosuspend(dev);