redisConnect() may return NULL

It's possible.  Better check for it

diff --git a/src/modules/rlm_redis/rlm_redis.c b/src/modules/rlm_redis/rlm_redis.c
index 993884c89574d78114cef58021780901e0faddd7..561e0f365d8dda01496154ff73e9f96f2173747d 100644 (file)
--- a/src/modules/rlm_redis/rlm_redis.c
+++ b/src/modules/rlm_redis/rlm_redis.c
@@ -64,6 +64,12 @@ static void *mod_conn_create(TALLOC_CTX *ctx, void *instance)
        char buffer[1024];
 
        conn = redisConnect(inst->hostname, inst->port);
+       if (!conn) {
+               ERROR("rlm_redis (%s): Failed calling redisConnect('%s', %d)",
+                     inst->xlat_name, inst->hostname, inst->port);
+               return NULL;
+       }
+
        if (conn && conn->err) {
                ERROR("rlm_redis (%s): Problems with redisConnect('%s', %d), %s",
                                inst->xlat_name, inst->hostname, inst->port, redisReplyReaderGetError(conn));