]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
frames: suppress cppcheck warning
authorVictor Julien <vjulien@oisf.net>
Fri, 2 Dec 2022 06:00:26 +0000 (07:00 +0100)
committerVictor Julien <vjulien@oisf.net>
Wed, 14 Dec 2022 19:04:40 +0000 (20:04 +0100)
src/app-layer-frames.c:471:5: warning: Identical condition 'stream_slice->input==NULL', second condition is always false [identicalConditionAfterEarlyExit]
    BUG_ON(stream_slice->input == NULL);
    ^
src/app-layer-frames.c:468:29: note: If condition 'stream_slice->input==NULL' is true, the function will return/exit
    if (stream_slice->input == NULL)
                            ^
src/app-layer-frames.c:471:5: note: Testing identical condition 'stream_slice->input==NULL'
    BUG_ON(stream_slice->input == NULL);
    ^
src/app-layer-frames.c:548:5: warning: Identical condition 'stream_slice->input==NULL', second condition is always false [identicalConditionAfterEarlyExit]
    BUG_ON(stream_slice->input == NULL);
    ^
src/app-layer-frames.c:545:29: note: If condition 'stream_slice->input==NULL' is true, the function will return/exit
    if (stream_slice->input == NULL)
                            ^
src/app-layer-frames.c:548:5: note: Testing identical condition 'stream_slice->input==NULL'
    BUG_ON(stream_slice->input == NULL);
    ^

src/app-layer-frames.c

index 62e150eb347fff1f086049c73517c5f72c422ad5..95683a5c703cb6cb68162eb18097154b956690c3 100644 (file)
@@ -467,8 +467,9 @@ Frame *AppLayerFrameNewByRelativeOffset(Flow *f, const StreamSlice *stream_slice
         return NULL;
     if (stream_slice->input == NULL)
         return NULL;
-#endif
+#else
     BUG_ON(stream_slice->input == NULL);
+#endif
     BUG_ON(f->proto == IPPROTO_TCP && f->protoctx == NULL);
     BUG_ON(f->alparser == NULL);
 
@@ -544,8 +545,9 @@ Frame *AppLayerFrameNewByAbsoluteOffset(Flow *f, const StreamSlice *stream_slice
         return NULL;
     if (stream_slice->input == NULL)
         return NULL;
-#endif
+#else
     BUG_ON(stream_slice->input == NULL);
+#endif
     BUG_ON(f->proto == IPPROTO_TCP && f->protoctx == NULL);
     BUG_ON(f->alparser == NULL);
     BUG_ON(frame_start < stream_slice->offset);