]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemuMonitorJSONMigrate: Drop 'detach' QMP option
authorPeter Krempa <pkrempa@redhat.com>
Wed, 21 May 2025 07:59:53 +0000 (09:59 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Wed, 21 May 2025 13:49:36 +0000 (15:49 +0200)
The argument was always ignored by qemu [1], as of qemu-10.1 it will be
deprecated. As it was always unused/ignored we can drop it without any
extra logic.

[1] qemu docs state:

   3. The user Monitor's "detach" argument is invalid in QMP and
     should not be used.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/qemu/qemu_monitor_json.c

index 3c2b35575eaa781edf9dcd4dc9a291a6c7a0acaf..a6fb2a201373e5f10534d9dbc369671c98c1b9e0 100644 (file)
@@ -3198,7 +3198,6 @@ int qemuMonitorJSONMigrate(qemuMonitor *mon,
 {
     bool resume = !!(flags & QEMU_MONITOR_MIGRATE_RESUME);
     g_autoptr(virJSONValue) cmd = qemuMonitorJSONMakeCommand("migrate",
-                                                             "b:detach", true,
                                                              "b:resume", resume,
                                                              "s:uri", uri,
                                                              NULL);